Skip to content

chore: Replace ESLint with Oxlint/Oxfmt#29

Merged
mahata merged 4 commits into
mainfrom
feat/oxlint
Jan 25, 2026
Merged

chore: Replace ESLint with Oxlint/Oxfmt#29
mahata merged 4 commits into
mainfrom
feat/oxlint

Conversation

@mahata

@mahata mahata commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

This pull request makes several key changes to migrate the project from ESLint to Oxlint/Oxfmt for linting and formatting, updates the CI workflow to reflect these tools, and applies consistent code style and formatting across the codebase and documentation. The most important changes are summarized below:

Tooling migration and configuration:

  • Replaces ESLint and related dependencies with oxlint and oxfmt in package.json, updates npm scripts accordingly, and removes the eslint.config.js file. [1] [2] [3]
  • Adds .oxlintrc.json and .oxfmtrc.json configuration files to define ignore patterns and set up linting/formatting rules. [1] [2]

CI workflow improvements:

  • Updates the GitHub Actions workflow to add a dedicated lint job using oxlint and oxfmt, ensures linting passes before running Playwright component tests, and upgrades pnpm to version 10. [1] [2] [3]

Codebase formatting and consistency:

Documentation updates:

  • Updates README.md to reflect the new linting and formatting tools, and ensures code samples use the new preferred style (double quotes, semicolons, etc.). [1] [2]

These changes collectively modernize the project's code quality tooling, enforce consistent code style, and improve the reliability of CI checks.

refactor: improve Post component structure and error handling
test: enhance post metadata extraction tests for edge cases
fix: correct post loading and parsing logic in posts utility
chore: update configuration files for consistency and clarity

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the project from ESLint to Oxlint/Oxfmt for linting and formatting, applies consistent code styling (double quotes and semicolons) across the codebase, and updates the CI workflow to incorporate the new tooling.

Changes:

  • Replaces ESLint and related dependencies with Oxlint v1.41.0 and Oxfmt v0.26.0 in package.json and removes eslint.config.js
  • Adds .oxlintrc.json and .oxfmtrc.json configuration files with ignore patterns for dist and playwright/.cache directories
  • Updates GitHub Actions workflow to add a dedicated lint job using oxlint and oxfmt that runs before Playwright tests, and upgrades pnpm to version 10
  • Applies consistent formatting changes throughout TypeScript, test, configuration, and markdown files (double quotes instead of single quotes, semicolons at statement ends, consistent indentation)

Reviewed changes

Copilot reviewed 93 out of 96 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates dependencies, removes ESLint packages, adds oxlint and oxfmt, updates npm scripts
.oxlintrc.json New configuration file for oxlint with ignore patterns
.oxfmtrc.json New configuration file for oxfmt with ignore patterns
eslint.config.js Removed - no longer needed after migration to oxlint
.github/workflows/test-ct.yml Adds lint job, updates workflow name, upgrades pnpm to v10, adds dependency between lint and test jobs
src//*.ts, src//*.tsx Formatting changes: double quotes, semicolons, consistent code style
*.md files (posts, fixtures) YAML front matter formatting updates to use double quotes
vite.config.ts, playwright-ct.config.ts, playwright.config.ts, tsconfig.json Formatting updates for consistency
README.md Code examples reformatted with double quotes and semicolons
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ErrorBoundaryProps,
ErrorBoundaryState
> {
export class ErrorBoundary extends Component<ErrorBoundaryProps, ErrorBoundaryState> {

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component state property 'error' is written, but it is never read.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copilot AI commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

@mahata I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* fix: utilize error state in ErrorBoundary component

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* fix: improve ErrorBoundary security and accessibility

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* refactor: improve ErrorBoundary error handling robustness

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* refactor: extract error formatting logic into helper method

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* fix: improve error message fallback handling for empty strings

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* refactor: replace inline styles with CSS module

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* Update src/components/ErrorBoundary.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: add comprehensive tests and production safety for ErrorBoundary

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* refactor: simplify error message clearing in test

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

* style: apply oxfmt formatting to ErrorBoundary files

Co-authored-by: mahata <23497+mahata@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mahata <23497+mahata@users.noreply.github.com>
Co-authored-by: Yasunori MAHATA <mahata777@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mahata mahata merged commit 20a346a into main Jan 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants