Fix for Rx boosted gain on LR1110 - #2844
Merged
Merged
Conversation
recrof
reviewed
Jun 25, 2026
recrof
reviewed
Jun 25, 2026
oltaco
force-pushed
the
fix-rx-boosted-gain
branch
from
June 25, 2026 22:45
a9cfacb to
b07aba7
Compare
Member
Author
|
Thanks @recrof didn't mean to include those 👍 |
liamcottle
reviewed
Jun 26, 2026
ViezeVingertjes
approved these changes
Jun 26, 2026
ViezeVingertjes
left a comment
ViezeVingertjes
left a comment
Contributor
There was a problem hiding this comment.
LGTM; did open a PR to yours with a few suggestions but those are more style/cleanup, so not mandatory. 👍🏼
(Still having nightmares of the LR1110 deafness problems when i read that type haha)
hermes-gadget
added a commit
to gadgethd/MeshCore-MQTT
that referenced
this pull request
Jun 27, 2026
Upstream dev: 3d4eec4..5ff39c6 (10 commits) - Merge PR meshcore-dev#2570: fix flash mode XiaoC6 - Merge PR meshcore-dev#2639: fix typos in comments - Merge PR meshcore-dev#2844: fix rx boosted gain - always save boosted gain setting - fix: report error when rxgain setting is unsupported/rejected - return bool when setting rx boost - remove guard on MyMesh::setRxBoostedGain() - fix: fix typos in source code comments (x2) - Added flash_mode=dio to avoid boot loop on merge.bin flash Integration work: - Resolved CommonCLI.cpp conflict: kept packPrefs/unpackPrefs architecture (upstream didn't touch CommonCLI.h in this window, --theirs was sufficient) - Squash merge of origin/main (all MQTT additions preserved) - Removed firmware binaries from webflasher/ - Added gitignore patterns All MQTT additions preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Rx boosted gain not being applied on LR1110 and improves the error handling when setting Rx boosted gain.
Previously LR1110 was never getting Rx boosted gain set due to an overly narrow guard condition in MyMesh. Nobody noticed that the override wasn't getting called because the call was void and the default was no-op so there was no error to report.
I have changed setRxBoostedGain() and setRxBoostedGainMode() to return bool and the default is to return false. Now errors can propagate back to CommonCLI so that we know when radio.rxgain is unsupported or the radio returned an error.
Tested on LR1110 (T1000e) and (RAK 4631).
Confirmed building on SX1268 (Meshadventurer) and ESPNOW (Heltec V3), untested but should be fine.