Skip to content

Update python3 version to 3.8 - #37

Closed
ferbncode wants to merge 1 commit into
metabrainz:masterfrom
ferbncode:python3.8
Closed

Update python3 version to 3.8#37
ferbncode wants to merge 1 commit into
metabrainz:masterfrom
ferbncode:python3.8

Conversation

@ferbncode

Copy link
Copy Markdown
Member

Update python3 version to python3.8. Updated the version for werkzeug and requests modules too as some modules were marked deprecated in 0.16.0 and we should start fixing them too.

@paramsingh paramsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'm wondering if we should hold off on merging this until we upgrade LB, CB and MsB to 3.8 too, thoughts?

@ferbncode

ferbncode commented Jan 3, 2020

Copy link
Copy Markdown
Member Author

Agreed, brainzutils-python already uses werkzeug==0.15.5, which fixes an issue with python 3.8 - pallets/werkzeug#1551 - CB currently uses old version of brainzutils-python. So, we can definitely wait to merge this after migrating other projects.

I expect updating the version here to not hurt (as it is not a major version change and we'd have to upgrade the brainzutils-python version in project anyways), but it would be nice to migrate at least one project before we release these changes.

@paramsingh

Copy link
Copy Markdown
Contributor

Sounds good.

@alastair

alastair commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator

lgtm but I'm wondering if we should hold off on merging this until we upgrade LB, CB and MsB to 3.8 too, thoughts?

yes, for sure. This also has to cover the python baseimages, and as we did when we did the last upgrade here, we should test each app using the PR branch before merging it for good.
For the baseimage upgrades, we need to make sure that the consul setup is working properly, I remember that we had some issues with this last time due to startup scripts in different apps expecting different consul configuration.

@alastair

Copy link
Copy Markdown
Collaborator

This is a small change and has conflicts. I'm going to close it in favour of #45, sorry for the 1 year delay!

@alastair alastair closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants