Gh 41788 incorrect output for esprivate with nested class in esnext - #42663
Merged
Nathan Shively-Sanders (sandersn) merged 7 commits intoApr 7, 2021
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Titian Cernicova-Dragomir (dragomirtitian)
marked this pull request as ready for review
February 5, 2021 16:11
Nathan Shively-Sanders (sandersn)
requested changes
Mar 9, 2021
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
I think it's missing a check that the property is static.
Contributor
Author
|
Nathan Shively-Sanders (@sandersn) Thank you for the review. I fixed the issues. Let me know if there are any others changes I should make. |
Titian Cernicova-Dragomir (dragomirtitian)
requested a review
from Nathan Shively-Sanders (sandersn)
March 11, 2021 09:15
Nathan Shively-Sanders (sandersn)
approved these changes
Apr 2, 2021
Member
|
Titian Cernicova-Dragomir (@dragomirtitian) Sorry for the delay on this. I tried merging from master but there are some changes in the emit that were so complex that I couldn't tell whether they were correct. Can you take a look? I'll merge after that. |
… if target:ESNext and useDefineForClassFields:false.
…true for target esnext
…ode review issues.
Titian Cernicova-Dragomir (dragomirtitian)
force-pushed
the
GH-41788-incorrect-output-for-esprivate-with-nested-class-in-esnext
branch
from
April 5, 2021 17:06
90e6067 to
dc0a347
Compare
Titian Cernicova-Dragomir (dragomirtitian)
requested a review
from Nathan Shively-Sanders (sandersn)
April 6, 2021 08:23
Nathan Shively-Sanders (sandersn)
approved these changes
Apr 7, 2021
Contributor
|
This also fixed #34787 |
Haoqun Jiang (haoqunjiang)
added a commit
to haoqunjiang/vite
that referenced
this pull request
Jul 14, 2021
Since TypeScript 4.3, `target: "esnext"` indicates that `useDefineForClassFields: true` as the new default. See <microsoft/TypeScript#42663> So I'm explicitly adding this field to the tsconfigs to avoid any confusions. Note that `lit-element` projects must use `useDefineForClassFields: false` because of <https://github.com/lit/lit-element/issues/1030> Vue projects must use `useDefineForClassFields: true` so as to support class style `prop` definition in `vue-class-component`: <vuejs/vue-class-component#465> Popular React state management library MobX requires it to be `true`: <https://mobx.js.org/installation.html#use-spec-compliant-transpilation-for-class-properties> Other frameworks seem to have no particular opinion on this. So I turned it on in all templates except for the `lit-element` one.
9 tasks
This was referenced Aug 26, 2021
Titian Cernicova-Dragomir (dragomirtitian)
deleted the
GH-41788-incorrect-output-for-esprivate-with-nested-class-in-esnext
branch
November 17, 2023 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41788
Fixed as described in comment