Use base constraint when testing whether a type needs an Awaited<T> wrapper - #51230
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Andrew Branch (andrewbranch) and
Wesley Wigham (weswigham)
October 19, 2022 16:21
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Ron Buckton (rbuckton)
changed the title
this type parameter in isRelatedTo fast pathAwaited<T> wrapper
Wesley Wigham (weswigham)
approved these changes
Oct 19, 2022
Andrew Branch (andrewbranch)
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we updated
awaitto useAwaited<T>in 4.5, we avoided introducing a newAwaited<T>wrapper whenTis a generic primitive by callingallTypesAssignableToKind. However, whenTis athistype, it triggers a circularity error. This change ensures we check against the base constraint ofTrather thanTitself, which avoids the circularity.Fixes #47291