Skip to content

Port of #51626 and #51689 to release-4.9 - #51627

Merged
Sheetal Nandi (sheetalkamat) merged 4 commits into
release-4.9from
fileTextNoChange49
Nov 30, 2022
Merged

Port of #51626 and #51689 to release-4.9#51627
Sheetal Nandi (sheetalkamat) merged 4 commits into
release-4.9from
fileTextNoChange49

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Porting #51626 and #51689 to release-4.9

@sheetalkamat
When fsEvent for change is repeated
0a01fcb
@sheetalkamat
When trying to check if program is uptodate, read the files from disk…
2de171b 
… to determine the version instead of delaying so that new program is not created if file contents have not changed
@sheetalkamat
Sheetal Nandi (sheetalkamat) changed the base branch from main to release-4.9 November 22, 2022 22:11
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 22, 2022
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Nov 22, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) pack this

@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Sheetal Nandi (@sheetalkamat), I've started to run the tarball bundle task on this PR at 2de171b. You can monitor the build here.

@sheetalkamat Sheetal Nandi (sheetalkamat) mentioned this pull request Nov 22, 2022
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Sheetal Nandi (@sheetalkamat), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/139076/artifacts?artifactName=tgz&fileId=FDFEBFD7D88247CD31A298D36CE4CF4D755D0D11C7B30BA428B6AB3F1180113F02&fileName=/typescript-4.9.3-insiders.20221122.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.9.3-pr-51627-2".;

DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Nov 29, 2022
View reviewed changes
Comment thread src/compiler/watchPublic.ts Outdated
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Nov 29, 2022

Copy link
Copy Markdown
Member

Apart from my comment, should this be taken out of draft state?

@sheetalkamat Sheetal Nandi (sheetalkamat) mentioned this pull request Nov 29, 2022
Merged
@sheetalkamat Sheetal Nandi (sheetalkamat) changed the title Port of #51626 to release-4.9 Port of #51626 and #51689 to release-4.9 Nov 29, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) marked this pull request as ready for review November 29, 2022 23:33
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit e7a02f4 into release-4.9 Nov 30, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the fileTextNoChange49 branch November 30, 2022 19:22
@cssecautomation cssecautomation mentioned this pull request May 16, 2023
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheetalkamat @typescript-bot @DanielRosenwasser