Cherry-pick #51704 to release 4.9 - #51712
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 2 commits intoDec 5, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Dec 1, 2022
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Approved, but would appreciate adding the test case anyway since 4.9.5 and other patch changes may come in.
|
Daniel Rosenwasser (@DanielRosenwasser) Do you guys currently think 4.9.4 is published? The code is set as merged and released from what I could tell but we can not install it and it has a critical regression fix for quite a few dependents. Just asking since this is expecting 4.9.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #51704 manually to the 4.9 branch. Testcase not included since this is a terminal branch