馃 Pick PR #52984 (Check for strict subtypes and then ...) into release-5.0 - #53085
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoMar 7, 2023
Conversation
Component commits: b3d3ec9 Use strictSubtypeRelation in getNarrowedType and narrow only for pure subtypes 0325f9d Accept new baselines 3df807f First check for strict subtypes, then check for regular subtypes d737eee Accept new baselines 9b2d602 Add tests 9ea8a55 Accept new baselines 8bb30e2 Add another repro
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Jake Bailey (jakebailey)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
March 4, 2023 00:02
Member
|
I tested the top 250 between |
Member
|
Actually, there are two issues that may be notable:
But I don't think they're related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #52984
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc Jake Bailey (@jakebailey)