Skip asking for jsdoc in checkObjectLiteral for enums in TS

[Jake Bailey (jakebailey)]

Pulling this out of #52641 as I think it's a good change to not waste time asking for JSDoc when we're not in JS code. The other half of that PR is a bigger change (even without baseline changes).

[Jake Bailey (jakebailey)]

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite (tsserver) on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite (tsserver) on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 9c60e41. You can monitor the build here.

[TypeScript Bot (typescript-bot)]

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 9c60e41. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/53117/merge:

Everything looks good!

[TypeScript Bot (typescript-bot)]

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/53117/merge:

Everything looks good!

[TypeScript Bot (typescript-bot)]

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53117

Metric	main	53117	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	359,788k (± 0.02%)	359,322k (± 0.01%)	-466k (- 0.13%)	359,284k	359,360k	p=0.005 n=6
Parse Time	3.48s (± 0.49%)	3.52s (± 0.89%)	+0.03s (+ 0.96%)	3.49s	3.56s	p=0.040 n=6
Bind Time	1.13s (± 0.67%)	1.13s (± 0.46%)	~	1.12s	1.13s	p=0.784 n=6
Check Time	8.65s (± 0.39%)	8.65s (± 0.41%)	~	8.62s	8.71s	p=0.872 n=6
Emit Time	7.42s (± 0.82%)	7.46s (± 0.56%)	~	7.40s	7.50s	p=0.227 n=6
Total Time	20.68s (± 0.37%)	20.75s (± 0.37%)	~	20.63s	20.84s	p=0.128 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	193,530k (± 1.58%)	192,576k (± 1.49%)	~	190,692k	196,290k	p=0.471 n=6
Parse Time	1.49s (± 0.55%)	1.48s (± 0.51%)	~	1.47s	1.49s	p=0.120 n=6
Bind Time	0.77s (± 0.72%)	0.77s (± 0.82%)	~	0.76s	0.78s	p=0.201 n=6
Check Time	9.39s (± 0.75%)	9.37s (± 1.14%)	~	9.22s	9.51s	p=1.000 n=6
Emit Time	2.74s (± 0.75%)	2.75s (± 0.88%)	~	2.71s	2.78s	p=0.871 n=6
Total Time	14.38s (± 0.57%)	14.37s (± 0.89%)	~	14.19s	14.53s	p=1.000 n=6
Monaco - node (v18.10.0, x64)
Memory used	343,847k (± 0.01%)	342,567k (± 0.01%)	-1,281k (- 0.37%)	342,533k	342,623k	p=0.005 n=6
Parse Time	2.62s (± 1.33%)	2.63s (± 0.88%)	~	2.59s	2.66s	p=0.872 n=6
Bind Time	1.01s (± 0.51%)	1.00s (± 0.98%)	-0.01s (- 1.15%)	0.99s	1.02s	p=0.037 n=6
Check Time	7.00s (± 0.46%)	6.98s (± 0.58%)	~	6.90s	7.02s	p=0.145 n=6
Emit Time	4.22s (± 1.11%)	4.20s (± 0.62%)	~	4.16s	4.24s	p=0.628 n=6
Total Time	14.87s (± 0.62%)	14.81s (± 0.28%)	~	14.74s	14.86s	p=0.298 n=6
TFS - node (v18.10.0, x64)
Memory used	299,861k (± 0.01%)	299,498k (± 0.00%)	-364k (- 0.12%)	299,487k	299,504k	p=0.005 n=6
Parse Time	2.03s (± 1.44%)	2.04s (± 0.79%)	~	2.01s	2.06s	p=0.250 n=6
Bind Time	1.14s (± 0.36%)	1.14s (± 0.86%)	~	1.13s	1.15s	p=0.487 n=6
Check Time	6.52s (± 1.34%)	6.49s (± 0.53%)	~	6.46s	6.55s	p=0.936 n=6
Emit Time	3.85s (± 1.06%)	3.86s (± 0.50%)	~	3.83s	3.88s	p=0.464 n=6
Total Time	13.54s (± 1.17%)	13.53s (± 0.29%)	~	13.48s	13.58s	p=0.294 n=6
material-ui - node (v18.10.0, x64)
Memory used	476,415k (± 0.01%)	476,198k (± 0.00%)	-217k (- 0.05%)	476,176k	476,235k	p=0.005 n=6
Parse Time	3.13s (± 0.72%)	3.13s (± 0.69%)	~	3.11s	3.16s	p=1.000 n=6
Bind Time	0.91s (± 0.83%)	0.91s (± 0.00%)	~	0.91s	0.91s	p=0.598 n=6
Check Time	17.11s (± 0.78%)	17.02s (± 0.36%)	~	16.94s	17.11s	p=0.230 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.16s (± 0.73%)	21.06s (± 0.38%)	~	20.95s	21.18s	p=0.229 n=6
xstate - node (v18.10.0, x64)
Memory used	548,900k (± 0.01%)	548,851k (± 0.02%)	~	548,717k	548,977k	p=0.575 n=6
Parse Time	4.08s (± 0.20%)	4.08s (± 0.46%)	~	4.06s	4.11s	p=0.732 n=6
Bind Time	1.67s (± 0.63%)	1.67s (± 1.40%)	~	1.65s	1.71s	p=0.743 n=6
Check Time	2.77s (± 0.74%)	2.77s (± 0.90%)	~	2.74s	2.81s	p=1.000 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.62s (± 0.33%)	8.61s (± 0.33%)	~	8.57s	8.66s	p=0.462 n=6
Angular - node (v16.17.1, x64)
Memory used	359,074k (± 0.01%)	358,610k (± 0.01%)	-464k (- 0.13%)	358,588k	358,641k	p=0.005 n=6
Parse Time	3.71s (± 0.33%)	3.71s (± 0.34%)	~	3.69s	3.72s	p=0.675 n=6
Bind Time	1.20s (± 0.43%)	1.20s (± 0.70%)	~	1.18s	1.20s	p=0.923 n=6
Check Time	9.42s (± 0.48%)	9.45s (± 0.34%)	~	9.42s	9.51s	p=0.418 n=6
Emit Time	7.89s (± 0.33%)	7.91s (± 0.35%)	~	7.89s	7.96s	p=0.220 n=6
Total Time	22.21s (± 0.17%)	22.27s (± 0.18%)	+0.06s (+ 0.26%)	22.22s	22.31s	p=0.024 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	193,446k (± 0.89%)	192,890k (± 0.71%)	~	192,312k	195,696k	p=0.297 n=6
Parse Time	1.56s (± 1.17%)	1.56s (± 1.10%)	~	1.54s	1.58s	p=0.563 n=6
Bind Time	0.82s (± 0.00%)	0.82s (± 0.63%)	~	0.82s	0.83s	p=0.174 n=6
Check Time	10.12s (± 0.62%)	10.11s (± 0.64%)	~	10.00s	10.17s	p=0.936 n=6
Emit Time	3.00s (± 1.11%)	3.00s (± 0.83%)	~	2.98s	3.05s	p=1.000 n=6
Total Time	15.50s (± 0.35%)	15.49s (± 0.51%)	~	15.37s	15.56s	p=1.000 n=6
Monaco - node (v16.17.1, x64)
Memory used	343,100k (± 0.01%)	341,838k (± 0.00%)	-1,262k (- 0.37%)	341,825k	341,860k	p=0.005 n=6
Parse Time	2.78s (± 0.44%)	2.79s (± 0.95%)	~	2.76s	2.84s	p=0.167 n=6
Bind Time	1.08s (± 0.48%)	1.08s (± 0.48%)	~	1.08s	1.09s	p=1.000 n=6
Check Time	7.69s (± 0.63%)	7.66s (± 0.35%)	~	7.62s	7.70s	p=0.257 n=6
Emit Time	4.41s (± 0.47%)	4.46s (± 0.93%)	+0.05s (+ 1.14%)	4.41s	4.51s	p=0.041 n=6
Total Time	15.96s (± 0.37%)	15.99s (± 0.49%)	~	15.87s	16.10s	p=0.574 n=6
TFS - node (v16.17.1, x64)
Memory used	299,242k (± 0.01%)	298,864k (± 0.01%)	-378k (- 0.13%)	298,820k	298,905k	p=0.005 n=6
Parse Time	2.16s (± 0.29%)	2.16s (± 0.86%)	~	2.14s	2.19s	p=1.000 n=6
Bind Time	1.25s (± 0.71%)	1.24s (± 1.39%)	~	1.21s	1.26s	p=0.215 n=6
Check Time	7.17s (± 0.29%)	7.14s (± 0.26%)	~	7.12s	7.17s	p=0.052 n=6
Emit Time	4.34s (± 0.43%)	4.33s (± 0.31%)	~	4.31s	4.34s	p=0.392 n=6
Total Time	14.92s (± 0.18%)	14.88s (± 0.29%)	~	14.82s	14.95s	p=0.063 n=6
material-ui - node (v16.17.1, x64)
Memory used	475,721k (± 0.02%)	475,432k (± 0.00%)	-288k (- 0.06%)	475,398k	475,446k	p=0.005 n=6
Parse Time	3.29s (± 0.23%)	3.27s (± 0.37%)	~	3.26s	3.29s	p=0.078 n=6
Bind Time	0.96s (± 0.78%)	0.96s (± 0.43%)	~	0.95s	0.96s	p=0.389 n=6
Check Time	18.09s (± 0.92%)	18.12s (± 0.92%)	~	17.94s	18.43s	p=0.936 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.34s (± 0.73%)	22.35s (± 0.71%)	~	22.19s	22.65s	p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used	546,423k (± 0.02%)	546,408k (± 0.02%)	~	546,309k	546,595k	p=0.575 n=6
Parse Time	4.26s (± 0.50%)	4.26s (± 0.53%)	~	4.24s	4.29s	p=0.627 n=6
Bind Time	1.77s (± 0.50%)	1.77s (± 0.59%)	~	1.75s	1.78s	p=0.452 n=6
Check Time	2.96s (± 0.21%)	2.96s (± 0.41%)	~	2.95s	2.98s	p=0.454 n=6
Emit Time	0.10s (± 5.34%)	0.09s (± 5.53%)	~	0.09s	0.10s	p=0.311 n=6
Total Time	9.09s (± 0.30%)	9.09s (± 0.18%)	~	9.07s	9.12s	p=0.622 n=6
Angular - node (v14.15.1, x64)
Memory used	352,860k (± 0.00%)	352,405k (± 0.00%)	-455k (- 0.13%)	352,395k	352,415k	p=0.005 n=6
Parse Time	3.70s (± 0.50%)	3.72s (± 0.53%)	~	3.69s	3.75s	p=0.105 n=6
Bind Time	1.25s (± 0.60%)	1.25s (± 0.67%)	~	1.24s	1.26s	p=0.172 n=6
Check Time	9.72s (± 0.47%)	9.78s (± 0.85%)	~	9.63s	9.88s	p=0.126 n=6
Emit Time	8.31s (± 0.51%)	8.38s (± 0.66%)	~	8.29s	8.41s	p=0.121 n=6
Total Time	22.98s (± 0.22%)	23.12s (± 0.49%)	~	22.89s	23.18s	p=0.065 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	187,644k (± 0.01%)	187,599k (± 0.02%)	-45k (- 0.02%)	187,532k	187,645k	p=0.031 n=6
Parse Time	1.56s (± 0.33%)	1.57s (± 0.74%)	~	1.56s	1.59s	p=0.191 n=6
Bind Time	0.84s (± 0.49%)	0.84s (± 0.48%)	~	0.84s	0.85s	p=0.218 n=6
Check Time	10.12s (± 0.44%)	10.15s (± 0.68%)	~	10.07s	10.24s	p=0.378 n=6
Emit Time	3.13s (± 1.07%)	3.12s (± 0.47%)	~	3.10s	3.14s	p=0.567 n=6
Total Time	15.65s (± 0.29%)	15.69s (± 0.39%)	~	15.63s	15.77s	p=0.470 n=6
Monaco - node (v14.15.1, x64)
Memory used	338,135k (± 0.01%)	336,879k (± 0.01%)	-1,256k (- 0.37%)	336,833k	336,916k	p=0.005 n=6
Parse Time	2.88s (± 0.54%)	2.88s (± 0.90%)	~	2.86s	2.93s	p=0.935 n=6
Bind Time	1.11s (± 1.74%)	1.10s (± 1.06%)	~	1.09s	1.12s	p=0.357 n=6
Check Time	8.08s (± 0.67%)	8.05s (± 1.03%)	~	7.96s	8.20s	p=0.470 n=6
Emit Time	4.70s (± 0.53%)	4.71s (± 1.44%)	~	4.63s	4.80s	p=0.809 n=6
Total Time	16.78s (± 0.40%)	16.74s (± 0.97%)	~	16.55s	17.02s	p=0.378 n=6
TFS - node (v14.15.1, x64)
Memory used	294,281k (± 0.00%)	293,910k (± 0.00%)	-371k (- 0.13%)	293,886k	293,924k	p=0.005 n=6
Parse Time	2.38s (± 0.51%)	2.39s (± 0.87%)	~	2.37s	2.42s	p=0.933 n=6
Bind Time	1.07s (± 0.76%)	1.07s (± 0.59%)	~	1.06s	1.08s	p=0.432 n=6
Check Time	7.44s (± 0.75%)	7.42s (± 0.51%)	~	7.37s	7.46s	p=0.574 n=6
Emit Time	4.29s (± 0.34%)	4.31s (± 0.70%)	~	4.28s	4.36s	p=0.193 n=6
Total Time	15.18s (± 0.43%)	15.19s (± 0.33%)	~	15.10s	15.25s	p=0.629 n=6
material-ui - node (v14.15.1, x64)
Memory used	471,375k (± 0.00%)	471,115k (± 0.01%)	-261k (- 0.06%)	471,074k	471,162k	p=0.005 n=6
Parse Time	3.44s (± 0.40%)	3.45s (± 0.74%)	~	3.42s	3.48s	p=0.745 n=6
Bind Time	1.00s (± 0.98%)	1.01s (± 1.16%)	~	0.99s	1.02s	p=0.314 n=6
Check Time	18.96s (± 0.37%)	18.93s (± 0.41%)	~	18.84s	19.05s	p=0.574 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.41s (± 0.28%)	23.39s (± 0.30%)	~	23.30s	23.50s	p=0.809 n=6
xstate - node (v14.15.1, x64)
Memory used	535,177k (± 0.00%)	535,172k (± 0.00%)	~	535,154k	535,184k	p=0.521 n=6
Parse Time	4.46s (± 0.57%)	4.47s (± 0.50%)	~	4.45s	4.51s	p=0.463 n=6
Bind Time	1.79s (± 0.50%)	1.80s (± 0.65%)	~	1.79s	1.82s	p=0.270 n=6
Check Time	3.17s (± 0.64%)	3.18s (± 0.37%)	~	3.17s	3.20s	p=0.326 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.51s (± 0.26%)	9.54s (± 0.27%)	~	9.50s	9.58s	p=0.147 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53117	6
Baseline	main	6

TSServer

Comparison Report - main..53117

Metric	main	53117	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,374ms (± 0.43%)	2,361ms (± 0.29%)	~	2,352ms	2,368ms	p=0.065 n=6
Req 2 - geterr	5,368ms (± 0.70%)	5,342ms (± 0.57%)	~	5,317ms	5,400ms	p=0.230 n=6
Req 3 - references	326ms (± 0.85%)	327ms (± 1.22%)	~	323ms	334ms	p=0.806 n=6
Req 4 - navto	286ms (± 0.88%)	285ms (± 0.89%)	~	280ms	287ms	p=0.459 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	81ms (± 5.46%)	80ms (± 4.20%)	~	78ms	87ms	p=0.391 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,545ms (± 1.02%)	2,511ms (± 1.24%)	-35ms (- 1.36%)	2,459ms	2,552ms	p=0.045 n=6
Req 2 - geterr	4,009ms (± 0.80%)	4,017ms (± 0.81%)	~	3,971ms	4,053ms	p=0.689 n=6
Req 3 - references	350ms (± 1.42%)	345ms (± 0.35%)	~	344ms	347ms	p=0.105 n=6
Req 4 - navto	293ms (± 0.41%)	292ms (± 0.45%)	~	291ms	294ms	p=0.070 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	76ms (± 9.47%)	74ms (± 7.36%)	~	68ms	81ms	p=0.462 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,163ms (± 0.34%)	3,161ms (± 0.28%)	~	3,144ms	3,167ms	p=0.936 n=6
Req 2 - geterr	1,603ms (± 1.54%)	1,610ms (± 1.67%)	~	1,569ms	1,641ms	p=0.630 n=6
Req 3 - references	105ms (± 1.78%)	103ms (± 0.96%)	~	102ms	104ms	p=0.085 n=6
Req 4 - navto	360ms (± 1.01%)	359ms (± 1.31%)	~	353ms	366ms	p=0.688 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	428ms (± 1.66%)	423ms (± 1.59%)	~	414ms	434ms	p=0.172 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,484ms (± 1.24%)	2,534ms (± 0.39%)	+50ms (+ 2.01%)	2,525ms	2,551ms	p=0.005 n=6
Req 2 - geterr	5,725ms (± 0.42%)	5,746ms (± 0.44%)	~	5,719ms	5,787ms	p=0.521 n=6
Req 3 - references	343ms (± 0.86%)	343ms (± 0.24%)	~	342ms	344ms	p=0.461 n=6
Req 4 - navto	277ms (± 0.81%)	276ms (± 0.96%)	~	273ms	280ms	p=0.252 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	91ms (± 4.41%)	94ms (± 2.60%)	~	90ms	96ms	p=0.416 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,679ms (± 0.79%)	2,681ms (± 0.48%)	~	2,657ms	2,695ms	p=1.000 n=6
Req 2 - geterr	4,367ms (± 0.59%)	4,348ms (± 0.62%)	~	4,308ms	4,376ms	p=0.423 n=6
Req 3 - references	362ms (± 0.60%)	361ms (± 0.52%)	~	358ms	363ms	p=0.170 n=6
Req 4 - navto	289ms (± 0.46%)	288ms (± 0.71%)	~	285ms	291ms	p=0.217 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	75ms (± 3.32%)	76ms (± 2.26%)	~	73ms	78ms	p=0.510 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,343ms (± 0.25%)	3,339ms (± 0.33%)	~	3,317ms	3,346ms	p=1.000 n=6
Req 2 - geterr	1,782ms (± 3.86%)	1,746ms (± 0.99%)	~	1,727ms	1,777ms	p=0.128 n=6
Req 3 - references	112ms (± 1.69%)	113ms (± 1.04%)	~	112ms	115ms	p=0.453 n=6
Req 4 - navto	346ms (± 1.61%)	345ms (± 0.98%)	~	340ms	348ms	p=0.513 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	433ms (± 1.06%)	433ms (± 0.86%)	~	427ms	438ms	p=1.000 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,594ms (± 0.76%)	2,561ms (± 0.32%)	-33ms (- 1.26%)	2,552ms	2,573ms	p=0.005 n=6
Req 2 - geterr	6,090ms (± 0.38%)	6,083ms (± 0.74%)	~	6,032ms	6,146ms	p=0.810 n=6
Req 3 - references	359ms (± 0.18%)	357ms (± 0.45%)	-2ms (- 0.51%)	355ms	359ms	p=0.049 n=6
Req 4 - navto	276ms (± 0.53%)	275ms (± 0.44%)	~	274ms	277ms	p=0.325 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	102ms (± 0.96%)	102ms (± 2.19%)	~	98ms	105ms	p=0.801 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,818ms (± 0.59%)	2,814ms (± 0.36%)	~	2,802ms	2,827ms	p=0.575 n=6
Req 2 - geterr	4,487ms (± 1.83%)	4,446ms (± 0.21%)	~	4,435ms	4,462ms	p=0.336 n=6
Req 3 - references	377ms (± 4.90%)	384ms (± 6.78%)	~	364ms	419ms	p=1.000 n=6
Req 4 - navto	294ms (± 1.36%)	294ms (± 1.46%)	~	287ms	297ms	p=0.746 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	96ms (± 9.23%)	89ms (± 7.99%)	~	76ms	95ms	p=0.228 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,663ms (± 0.75%)	3,651ms (± 0.29%)	~	3,638ms	3,666ms	p=0.229 n=6
Req 2 - geterr	1,849ms (± 0.36%)	1,847ms (± 0.78%)	~	1,829ms	1,864ms	p=0.873 n=6
Req 3 - references	130ms (± 2.46%)	129ms (± 2.10%)	~	125ms	132ms	p=0.405 n=6
Req 4 - navto	374ms (± 0.77%)	375ms (± 0.31%)	~	373ms	376ms	p=0.125 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	455ms (± 2.22%)	455ms (± 2.45%)	~	437ms	469ms	p=0.872 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53117	6
Baseline	main	6

Startup

Comparison Report - main..53117

Metric	main	53117	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	141.44ms (± 0.20%)	141.51ms (± 0.24%)	~	140.46ms	145.33ms	p=0.086 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	226.66ms (± 0.16%)	226.49ms (± 0.18%)	-0.17ms (- 0.07%)	225.06ms	230.32ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	228.58ms (± 0.16%)	228.35ms (± 0.19%)	-0.23ms (- 0.10%)	226.96ms	233.28ms	p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	209.21ms (± 0.14%)	209.37ms (± 0.21%)	+0.15ms (+ 0.07%)	207.90ms	214.91ms	p=0.006 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53117	6
Baseline	main	6

Developer Information:

Download Benchmark

[TypeScript Bot (typescript-bot)]

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/53117/merge:

Everything looks good!

[TypeScript Bot (typescript-bot)]

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/53117/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

⚠️ Note that built had errors ⚠️

Exited unexpectedly with signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

{"seq":6849,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/packages/techdocs-cli/e2e-test.config.js"}}
{"seq":6850,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/techdocs-cli/e2e-test.config.js","line":19,"offset":48,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":"/"}}
{"seq":6851,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/techdocs-cli-embedded-app/src/components/Root/index.ts"],"openFiles":[]}}
{"seq":6852,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/techdocs-cli/e2e-tests/techdocs-cli.test.ts","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro Steps

1. git clone https://github.com/backstage/backstage --recurse-submodules
2. In dir backstage, run git reset --hard 6cea151d3349a4c4eb5201f9328e114752183a8b
3. Install packages (exact steps are below, but it might be easier to follow the repo readme)

   1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
   2. In dir backstage/microsite-next, run yarn install --no-immutable --mode=skip-build
   3. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
   4. In dir backstage, run yarn install --no-immutable --mode=skip-build
   5. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
4. Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
5. npm install --no-save @typescript/server-replay
6. npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

balena-io/etcher

⚠️ Note that built had errors ⚠️

Exited unexpectedly with signal SIGABRT

Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults3/balena-io.etcher.rawError.txt in the artifact folder

Last few requests

{"seq":1644,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/app/components/source-selector/source-selector.tsx","line":81,"offset":23,"entryNames":[{"name":"NoParamCallback","source":"fs","data":{"exportName":"NoParamCallback","exportMapKey":"NoParamCallback|10968|fs","moduleSpecifier":"fs","ambientModuleName":"fs"}}]}}
{"seq":1645,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/app/components/source-selector/source-selector.tsx","line":81,"offset":23,"entryNames":[{"name":"NoParamCallback","source":"original-fs","data":{"exportName":"NoParamCallback","exportMapKey":"NoParamCallback|10968|original-fs","moduleSpecifier":"original-fs","ambientModuleName":"original-fs"}}]}}
{"seq":1646,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/app/components/source-selector/source-selector.tsx","line":81,"offset":23,"entryNames":[{"name":"Normalize","source":"react-i18next","data":{"exportName":"Normalize","exportMapKey":"Normalize|14425|","moduleSpecifier":"react-i18next","fileName":"@PROJECT_ROOT@/node_modules/react-i18next/ts4.1/index.d.ts"}}]}}
{"seq":1647,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/app/components/source-selector/source-selector.tsx","line":81,"offset":23,"entryNames":[{"name":"Normalize2","source":"react-i18next","data":{"exportName":"Normalize2","exportMapKey":"Normalize2|14424|","moduleSpecifier":"react-i18next","fileName":"@PROJECT_ROOT@/node_modules/react-i18next/ts4.1/index.d.ts"}}]}}

Repro Steps

1. git clone https://github.com/balena-io/etcher --recurse-submodules
2. In dir etcher, run git reset --hard a0fc9bbd68d72ef91999c8b1bf0e973a08711bca
3. In dir etcher, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
4. Back in the initial folder, download RepoResults3/balena-io.etcher.replay.txt from the artifact folder
5. npm install --no-save @typescript/server-replay
6. npx tsreplay ./etcher ./balena-io.etcher.replay.txt path/to/tsserver.js
7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

[TypeScript Bot (typescript-bot)]

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.