Skip to content

fix(54992): Negative constant enums return number when toString is called - #55031

Closed
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/54992
Closed

fix(54992): Negative constant enums return number when toString is called#55031
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/54992

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Jul 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Jul 15, 2023
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review July 15, 2023 20:11
Andarist
Mateusz Burzyński (Andarist) reviewed Jul 15, 2023
View reviewed changes
Comment thread src/compiler/checker.ts Outdated
Andarist
Mateusz Burzyński (Andarist) reviewed Jul 15, 2023
View reviewed changes
Comment thread src/compiler/checker.ts Outdated
Andarist
Mateusz Burzyński (Andarist) reviewed Jul 15, 2023
View reviewed changes
Comment thread tests/cases/conformance/constEnums/constEnumPropertyAccess3.ts Outdated
Andarist
Mateusz Burzyński (Andarist) reviewed Jul 15, 2023
View reviewed changes
Comment thread src/compiler/transformers/ts.ts Outdated
@Andarist

Mateusz Burzyński (Andarist) commented Jul 15, 2023

Copy link
Copy Markdown
Contributor

Adding parenthesis could create other problems - but I guess that's not really possible since the emitter prefers semicolons. Is that right? Or am I missing some edge cases in which an accidental function call could be created?

@jakebailey

Jake Bailey (jakebailey) commented Jul 18, 2023

Copy link
Copy Markdown
Member

What happened to this PR? Was it totally wrong in some way?

FWIW, here's what esbuild does; thankfully doesn't have this problem, but my recollection of this PR before it was force pushed to empty was that this PR matched.

@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

Jake Bailey (@jakebailey) I've closed it in favor of Mateusz Burzyński (@Andarist)'s PR.

@jakebailey

Jake Bailey (jakebailey) commented Jul 18, 2023

Copy link
Copy Markdown
Member

Which PR is that? #55018 is for a different bug, and I'm not seeing any other enum PRs...

@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

I believe Mateusz Burzyński (@Andarist) will create a new PR soon.

@Andarist Mateusz Burzyński (Andarist) mentioned this pull request Jul 18, 2023
Merged
@Andarist

Mateusz Burzyński (Andarist) commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

here it is: #55065

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Andarist Mateusz Burzyński (Andarist) Andarist left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-tarasyuk @Andarist @jakebailey @typescript-bot