Revert PR 56087 - #57849
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoMar 19, 2024
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Wesley Wigham (weswigham)
March 19, 2024 17:38
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Member
Author
|
FWIW this will likely not cherry-pick without manual intervention because of the baseline change. |
Jake Bailey (jakebailey)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
March 19, 2024 17:40
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Mar 19, 2024
Member
Author
|
Sent #57850 for 5.4. |
Wesley Wigham (weswigham)
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #56087. That PR was a fix for a bug present in all versions of TS, but caused 2 more bugs and a perf regression in 5.4. It may be the case that #57396 fixes all of these, but that PR introduces a lot more code and is still in discussion,
Fixes #57843
Fixes #57781
Fixes #57357
Reopens #49171
Not sure if I'm reading the baselines correctly, but since this is removing the perf baseline, I guess the new baselines would have caught this regression as before the revert, there are some 3.2k types, but after, it's under the 100 type threshold? And similarly for symbols.