Fix a memory corruption problem in git multi-pack-index expire - #142
Closed
Johannes Schindelin (dscho) wants to merge 1 commit into
Closed
Fix a memory corruption problem in git multi-pack-index expire#142Johannes Schindelin (dscho) wants to merge 1 commit into
git multi-pack-index expire#142Johannes Schindelin (dscho) wants to merge 1 commit into
Conversation
When we close a pack, it might still be in the Most-Recently-Used list. If we truly want to remove it (and release its memory), we have to remove it from that list first. This fixes a complaint by valgrind, and a segmentation fault on Windows (where nedmalloc stumbles right over the overwritten memory). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Johannes Schindelin (dscho)
requested a review
from Derrick Stolee (derrickstolee)
May 27, 2019 09:27
Member
Author
|
Oops. This is not an issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I, or more correctly: our Pipeline, noticed this in #140. Running t5319 through
valgrinddid help diagnose this pretty quickly.