The constructor left it indeterminate, so a non-static timer is linked - #865
Merged
Conversation
mjp41
approved these changes
Jul 27, 2026
| friend class PalList; | ||
|
|
||
| stl::Atomic<PalTimerObject*> pal_next; | ||
| stl::Atomic<PalTimerObject*> pal_next = nullptr; |
Member
There was a problem hiding this comment.
I have a slight preference for:
Suggested change
| stl::Atomic<PalTimerObject*> pal_next = nullptr; | |
| stl::Atomic<PalTimerObject*> pal_next{nullptr}; |
I found sometimes the = nullptr can prevent static constexpr working properly.
into PalTimer's list with a garbage next pointer that apply_all then dereferences. PalNotificationObject already initialises its equivalent.
devnexen
force-pushed
the
pal_ds_dangling_fix
branch
from
July 27, 2026 13:39
65c9893 to
05a17da
Compare
mjp41
enabled auto-merge (squash)
July 27, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
into PalTimer's list with a garbage next pointer that apply_all then dereferences. PalNotificationObject already initialises its equivalent.