Support Update Display Data by rchiodo · Pull Request #10874 · microsoft/vscode-python

Rich Chiodo (rchiodo) · 2020-03-30T22:57:31Z

For #10873

We've never handled the update_display_data message correctly as it can affect other cells. This is necessary to get some ipywidgets to work correctly.

Rich Chiodo (rchiodo) · 2020-03-30T23:04:00Z

Debating with myself if I should add a functional test for this. Probably makes sense to

Ian Huff (IanMatthewHuff) · 2020-03-30T23:21:47Z

+                const data: nbformat.ICodeCell = c.cell.data as nbformat.ICodeCell;
+                const changedOutputs = data.outputs.map(o => {
+                    if (
+                        o.output_type === 'display_data' &&


Display data can update both execute_result and display_data outputs. I think you would need that here as well.
https://jupyter-client.readthedocs.io/en/stable/messaging.html#display-data

Codecov (codecov-io) · 2020-03-30T23:43:06Z

Codecov Report

Merging #10874 into master will decrease coverage by 34.65%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##           master   #10874       +/-   ##
===========================================
- Coverage   60.68%   26.02%   -34.66%     
===========================================
  Files         580      328      -252     
  Lines       31525    17530    -13995     
  Branches     4479     2498     -1981     
===========================================
- Hits        19130     4563    -14567     
- Misses      11425    12933     +1508     
+ Partials      970       34      -936

Impacted Files	Coverage Δ
...rc/client/common/application/webPanels/webPanel.ts	`11.84% <ø> (ø)`
...ent/common/application/webPanels/webPanelServer.ts	`12.67% <ø> (-61.98%)`	⬇️
.../datascience/interactive-common/interactiveBase.ts	`5.55% <0.00%> (-0.07%)`	⬇️
...ience/interactive-common/interactiveWindowTypes.ts	`100.00% <100.00%> (ø)`
src/client/debugger/constants.ts	`0.00% <0.00%> (-100.00%)`	⬇️
src/client/language/braceCounter.ts	`5.40% <0.00%> (-94.60%)`	⬇️
src/client/language/textBuilder.ts	`8.69% <0.00%> (-91.31%)`	⬇️
src/client/language/characterStream.ts	`4.41% <0.00%> (-89.71%)`	⬇️
src/client/language/tokenizer.ts	`4.08% <0.00%> (-89.22%)`	⬇️
...t/terminals/codeExecution/terminalCodeExecution.ts	`14.54% <0.00%> (-85.46%)`	⬇️
... and 462 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e964f...5f1b982. Read the comment docs.

Ian Huff (IanMatthewHuff) · 2020-03-30T23:59:33Z

+
+    private async handleKernelMessage(msg: KernelMessage.IIOPubMessage, _requestId: string) {
+        // Only care about one sort of message, UpdateDisplayData
+        if (KernelMessage.isUpdateDisplayDataMsg(msg)) {


I think this is a case where we need to lazy load jupyterlab services.

Ian Huff (IanMatthewHuff)

Approved with lazy load of Jupyter, at least from my perspective.

Don Jayamanne (DonJayamanne)

Rich Chiodo (@rchiodo) do we need these changes even after my new ipywidget implementation?
I can see AML widget working.
However we have changes in our react code to deal with update display data. Is that still required?

Rich Chiodo (rchiodo) · 2020-03-31T16:47:37Z

Rich Chiodo (@rchiodo) do we need these changes even after my new ipywidget implementation?
I can see AML widget working.
However we have changes in our react code to deal with update display data. Is that still required?

Yes for other reasons. This code doesn't work without it but it does in jupyter:

# %%
import itertools
import time

from IPython.display import Markdown


# %%

dh = display(display_id=True)


# %%
display(Markdown('# Display Update Fun'))
dh.display(Markdown(''))


# %%
for i in itertools.cycle(range(0x1F600, 0x1F650)):
    dh.update(Markdown(f'## &#{i}; {hex(i)}'))
    time.sleep(0.5)

sonarqubecloud · 2020-03-31T17:25:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

No Coverage information
1.1% Duplication

Rich Chiodo (rchiodo) marked this pull request as ready for review March 30, 2020 23:03

Rich Chiodo (rchiodo) requested review from David Kutugata (DavidKutu), Don Jayamanne (DonJayamanne) and Ian Huff (IanMatthewHuff) March 30, 2020 23:03

Rich Chiodo (rchiodo) self-assigned this Mar 30, 2020

Ian Huff (IanMatthewHuff) requested changes Mar 30, 2020

View reviewed changes

Rich Chiodo (rchiodo) added 7 commits March 30, 2020 16:23

Bunch of logging and getting azureml debug bits

b5836f8

Get rid of second view

5ea899c

Implement update_display_data

1d80e34

Add news entry

b5cced0

Remove unnecessary jquery

509ef7e

Remove stylesheet from html

1aa4204

Add test

caeddae

Rich Chiodo (rchiodo) force-pushed the rchiodo/aml_widgets_2 branch from fdbc150 to caeddae Compare March 30, 2020 23:24

Add execute_result for update_display_data handling

dedeb4b

Rich Chiodo (rchiodo) requested a review from Ian Huff (IanMatthewHuff) March 30, 2020 23:35

Ian Huff (IanMatthewHuff) reviewed Mar 30, 2020

View reviewed changes

Ian Huff (IanMatthewHuff) approved these changes Mar 31, 2020

View reviewed changes

Rich Chiodo (rchiodo) added 9 commits March 30, 2020 17:10

Fix dependencies and only pull in the type from jupyterlab services

31cf944

Fix importing jupyterlab services

4231944

Merge remote-tracking branch 'origin/master' into rchiodo/aml_widgets_2

9213f6e

Prettier format

a85d14c

Merge remote-tracking branch 'origin/master' into rchiodo/aml_widgets_2

a5443cd

Fix prettier again

eb3bc31

Fix hygiene

48859fc

Potential fix for functional failures

a7fbfad

More hygiene issues

9a8bf08

Don Jayamanne (DonJayamanne) approved these changes Mar 31, 2020

View reviewed changes

Don Jayamanne (DonJayamanne) requested changes Mar 31, 2020

View reviewed changes

Fix functional tests

5d43401

Don Jayamanne (DonJayamanne) approved these changes Mar 31, 2020

View reviewed changes

Fix unit tests

5f1b982

Rich Chiodo (rchiodo) merged commit 7a58ce8 into master Mar 31, 2020

Rich Chiodo (rchiodo) deleted the rchiodo/aml_widgets_2 branch March 31, 2020 18:08

lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020

Navigation Menu

Uh oh!

Support Update Display Data - #10874

Support Update Display Data#10874
Rich Chiodo (rchiodo) merged 19 commits into
masterfrom
rchiodo/aml_widgets_2

Rich Chiodo (rchiodo) commented Mar 30, 2020

Uh oh!

Rich Chiodo (rchiodo) commented Mar 30, 2020

Uh oh!

Ian Huff (IanMatthewHuff) Mar 30, 2020

Uh oh!

Rich Chiodo (rchiodo) Mar 30, 2020

Uh oh!

Codecov (codecov-io) commented Mar 30, 2020 •

edited

Loading

Uh oh!

Ian Huff (IanMatthewHuff) Mar 30, 2020

Uh oh!

Ian Huff (IanMatthewHuff) left a comment

Uh oh!

Don Jayamanne (DonJayamanne) left a comment •

edited

Loading

Uh oh!

Rich Chiodo (rchiodo) commented Mar 31, 2020

Uh oh!

sonarqubecloud Bot commented Mar 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Rich Chiodo (rchiodo) commented Mar 30, 2020

Uh oh!

Rich Chiodo (rchiodo) commented Mar 30, 2020

Uh oh!

Ian Huff (IanMatthewHuff) Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

Rich Chiodo (rchiodo) Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

Codecov (codecov-io) commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Ian Huff (IanMatthewHuff) Mar 30, 2020

Choose a reason for hiding this comment

Uh oh!

Ian Huff (IanMatthewHuff) left a comment

Choose a reason for hiding this comment

Uh oh!

Don Jayamanne (DonJayamanne) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rich Chiodo (rchiodo) commented Mar 31, 2020

Uh oh!

sonarqubecloud Bot commented Mar 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Codecov (codecov-io) commented Mar 30, 2020 •

edited

Loading

Don Jayamanne (DonJayamanne) left a comment •

edited

Loading