fix: Raise StreamableHTTPError on reconnection failure#3098
Open
wukath wants to merge 6 commits into
Open
Conversation
d7b5872 to
762dfb3
Compare
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…entry to fix branch coverage on Python 3.11+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Raise
StreamableHTTPErroron reconnection failure when the GET stream connection fails and exceedsMAX_RECONNECTION_ATTEMPTSinstead of returning silently.Currently, when the GET stream connection fails and exceeds
MAX_RECONNECTION_ATTEMPTS, the transport receive loop returns silently. This prevents the failure from propagating out of the transport receive loop, causing downstream agents/sessions to hang rather than cleanly identifying the disconnection and reporting the failure.Fixes google/adk-python#2615.
How Has This Been Tested?
pytestlocally to verify all transport tests pass.Breaking Changes
No breaking changes. This corrects silent failures and hangs into expected transport exception propagation.
Types of changes
Checklist
Additional context