Include links to the Evergreen build and to the driver security testing summary in the SSDLC report - #1426
Conversation
…ng summary in the SSDLC report JAVA-5500
…pute the Evergreen URL JAVA-5500
| declare -r EVERGREEN_PROJECT_NAME_SUFFIX="${PRODUCT_VERSION%.*}" | ||
| declare -r EVERGREEN_BUILD_URL="${EVERGREEN_BUILD_URL_PREFIX}/${EVERGREEN_PROJECT_NAME_PREFIX}_${EVERGREEN_PROJECT_NAME_SUFFIX}_${GIT_COMMIT_HASH}" | ||
| elif [[ "${PRODUCT_NAME}" == *'-snapshot' ]]; then | ||
| declare -r EVERGREEN_BUILD_URL="https://no-url-for-snapshot-builds" |
There was a problem hiding this comment.
We currently use a placeholder URL (https://no-url-for-snapshot-builds) in the report. Since we don't own this domain, there's some risk it could be registered and misused, potentially exposing viewers to unexpected content if they click on or visit the link expecting legitimate information. I suggest replacing it with a non-clickable message, such as 'No URL available for snapshot builds.
| declare -r EVERGREEN_BUILD_URL="https://no-url-for-snapshot-builds" | |
| declare -r EVERGREEN_BUILD_URL="There is no URL available for snapshot builds" |
| PRODUCT_NAME: ${product_name} | ||
| PRODUCT_VERSION: ${product_version} | ||
| PRODUCT_RELEASE_CREATOR: ${author} | ||
| EVERGREEN_VERSION_ID: ${version_id} |
There was a problem hiding this comment.
@vbabanin proposed a great idea to use Evergreen default expansions instead of trying to compute the required information on our own. Implementing this proposal greatly simplified the PR. However, I don't see how to test the new approach for builds triggered by a Git tag. We will see today how that works when releasing 5.1.2.
…ng summary in the SSDLC report (mongodb#1426) JAVA-5500
2 participants
The PR implements the requirements specified in this comment.
The example report produced with the changes in this PR is here. Note that it does not contain a valid Evergreen build URL, because it does not seem possible to compute such a URL for a snapshot build.
If you want to check the Evergreen URL computed for major/minor/patch releases, run the following manually (you can cancel the execution as soon as it prints
Evergreen build URL: ..., which happens right at the beginning), and check the URL printed:env PRODUCT_NAME=mongo-java-driver PRODUCT_VERSION=5.1.1 ./.evergreen/ssdlc-report.sh(you can play with thePRODUCT_VERSIONvalue to see the URL for different kinds of releases).JAVA-5500