Skip to content

feat: Replace fetch with fetchAssociative - #63

Merged
CarlSchwan merged 3 commits into
mainfrom
carl/replace-fetch
Nov 20, 2025
Merged

feat: Replace fetch with fetchAssociative#63
CarlSchwan merged 3 commits into
mainfrom
carl/replace-fetch

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Motivation and context

See nextcloud/server#56494

How has this been tested?

Ran this on server

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@CarlSchwan CarlSchwan mentioned this pull request Nov 17, 2025
Merged
7 tasks
@CarlSchwan CarlSchwan added the enhancement New feature or request label Nov 17, 2025
@CarlSchwan
CarlSchwan requested a review from come-nc November 17, 2025 11:25
provokateurin
provokateurin reviewed Nov 17, 2025
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test covering all scenarios would be very good.

come-nc
come-nc reviewed Nov 18, 2025
View reviewed changes

@come-nc come-nc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick and test needed, otherwise good job.

Comment thread src/Rector/ReplaceFetchAllMethodCallRector.php
@CarlSchwan

CarlSchwan commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

A test covering all scenarios would be very good.

Done

@CarlSchwan
CarlSchwan marked this pull request as ready for review November 20, 2025 15:09
ChristophWurst
ChristophWurst approved these changes Nov 20, 2025
View reviewed changes
Comment thread tests/Rector/ReplaceFetchAllMethodCallRector/ReplaceFetchAllMethodCallRectorTest.php Outdated
Comment thread tests/Rector/ReplaceFetchAllMethodCallRector/Fixture/test_fixture_fetch.php.inc
Comment thread tests/Rector/ReplaceFetchAllMethodCallRector/config/config.php
@CarlSchwan
CarlSchwan force-pushed the carl/replace-fetch branch 2 times, most recently from 22b5625 to 3588be7 Compare November 20, 2025 17:11
@CarlSchwan
feat: Replace fetch with fetchAssociative
7392f57 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
chore(replace-fetch-all-method-rector): Add unit test
7923a34 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
fix(style): Fix some code style issue
defb723 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan merged commit 2332529 into main Nov 20, 2025
22 checks passed
@CarlSchwan
CarlSchwan deleted the carl/replace-fetch branch November 20, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin left review comments
@come-nc come-nc come-nc left review comments
@ChristophWurst ChristophWurst ChristophWurst approved these changes
@kesselb kesselb kesselb approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @ChristophWurst @kesselb @provokateurin @come-nc