fix(wizard): align reauthentication with account setup - #10459
Conversation
Replace the legacy QWidget reauthentication dialog with a QML window that shares the account wizard browser-auth content, footer, dimensions, and style tokens. Keep credential replacement isolated from account creation and remove the unreachable provider-signup widget stack and its orphaned helpers. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1957df8f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Qt.CustomizeWindowHint | ||
| | Qt.WindowTitleHint | ||
| | Qt.WindowSystemMenuHint | ||
| | Qt.WindowMinimizeButtonHint |
There was a problem hiding this comment.
When opening any existing WizardStyledWindow consumer, this base-level flag now adds minimize decoration to ActivitiesWindow.qml, AssistantWindow.qml, SearchWindow.qml, and UserStatusWindow.qml; previously only AccountWizardWindow.qml explicitly opted into minimization. Keep this hint on the account and reauthentication windows, or explicitly preserve the existing chrome for the other consumers, so the reauthentication refactor does not change unrelated windows.
AGENTS.md reference: AGENTS.md:L25-L27
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f03bdf0288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f03bdf0 to
c1957df
Compare
Replaced the direct successful slotAuthResult() test with integration coverage through WebFlowCredentials::askFromUser(). Exercises real QML window creation, browser-flow polling, credential replacement, persistence invocation, automatic close, and account-registration safety. Added cancellation coverage by closing the actual QML window and verifying credentials remain unchanged. Added a safe Application null guard for standard Qt test runners. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
|
@claucambra can you check the quite complex test? it applied the new guidelines - but look complicated. opinion? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90296ac1d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
- Scoped minimize-button support to account and reauthentication windows. - Updated regression assertions for shared-default versus reauthentication behavior. - Replaced magic footer widths with uniformCellSizes. - Inlined BrowserAuthPage and removed BrowserReAuthPage.qml plus its resource entry. - Applied the C++ const, QVariantMap, and queued invokeMethod cleanups. - Kept the two height tokens separate because they represent different UI contracts. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <Rello@users.noreply.github.com>
|
Artifact containing the AppImage: nextcloud-appimage-pr-10459.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
3 participants
Replace the legacy QWidget reauthentication dialog with a QML window that shares the account wizard browser-auth content, footer, dimensions, and style tokens.
Keep credential replacement isolated from account creation and remove the unreachable provider-signup widget stack and its orphaned helpers.
Assisted-by: Codex:GPT-5