fix(caldav): explicitly check from component types - #48131
Merged
Conversation
miaulalala
requested review from
ChristophWurst and
tcitworld
as code owners
September 17, 2024 11:01
miaulalala
requested review from
a team,
Altahrim,
skjnldsv,
st3iny,
tcitworld and
yemkareems
and removed request for
a team,
ChristophWurst and
tcitworld
September 17, 2024 11:02
miaulalala
added
3. to review
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
ChristophWurst
approved these changes
Sep 17, 2024
miaulalala
force-pushed
the
fix/filter-for-components-explicitly
branch
from
September 17, 2024 14:44
b90e8f0 to
a65cf51
Compare
miaulalala
enabled auto-merge
September 17, 2024 15:56
Member
|
Could you make the PR description a bit more verbose? |
Member
|
/backport to stable31 |
AndyScherzinger
force-pushed
the
fix/filter-for-components-explicitly
branch
from
January 26, 2025 12:24
a65cf51 to
cd306b8
Compare
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
July 30, 2026 12:07
64377b7 to
649c10a
Compare
SebastianKrupinski
approved these changes
Jul 30, 2026
tcitworld
reviewed
Jul 30, 2026
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
3 times, most recently
from
July 31, 2026 11:51
e39c982 to
5372443
Compare
kesselb
approved these changes
Jul 31, 2026
kesselb
left a comment
kesselb
left a comment
Contributor
There was a problem hiding this comment.
Some tests would be nice ;)
The exceptions should be documented.
getDenormalizedData might be good fit to move into a own helper / service.
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
3 times, most recently
from
August 4, 2026 12:59
390d867 to
f4323a8
Compare
SebastianKrupinski
requested review from
come-nc,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
August 4, 2026 12:59
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/filter-for-components-explicitly
branch
from
August 4, 2026 13:09
f4323a8 to
5b1bd2e
Compare
Contributor
I added a few test cases for the other component types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore everything but the specific component types that are defined as valid in the RFC. We should only denormalize data that is actually valid, and skip any invalid data structures. Otherwise we run into the danger of returning trash data.
TODO
Checklist