docs(settings): Removing the developerDocsUrl

[Arsalanulhaq]

Summary

Removing the developerDocsUrl

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[kesselb]

Thanks for your pr 🙏

[kesselb]

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

[Arsalanulhaq]

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

Hi @kesselb
So, should we remove the generated developerDocsUrl link in AppsSettingsController.php and its usage in the AppStoreNavigation.vue file directly from the code? Is this link generated or used anywhere else? Because removing it will prevent users from seeing/navigating to the developer documentation.

[kesselb]

Thank you @Arsalanulhaq 🙏

[come-nc]

1) OCA\Settings\Tests\Controller\AppSettingsControllerTest::testViewApps
Expectation failed for method name is "provideInitialState" when invoked 4 times.
Method was expected to be called 4 times, actually called 3 times.

2) OCA\Settings\Tests\Controller\AppSettingsControllerTest::testViewAppsAppstoreNotEnabled
Expectation failed for method name is "provideInitialState" when invoked 4 times.
Method was expected to be called 4 times, actually called 3 times.

tests needs to be adapted

[come-nc]

/compile /

[printminion-co]

/backport to stable31

[printminion-co]

/backport to stable32