Client Certificate Authentication Support - #58210
Conversation
Client Certificate Authentication Support Signed-off-by: rhclayto <h+github@2milebridge.com>
|
Code from #52198 . |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
I don't think it's good to unconditionally send the client certificates for all requests. The correct approach would probably be to allow configuring client certificates per domain. The configuration being something like $CONFIG = [
'http_client_tls' = [
'example.com' => [
'cert' => '...',
'key' => '...',
],
],
]; |
Client Certificate Authentication Support
Summary
TODO
Checklist
3. to review, feature component)stable32)