Fix IP range null safety and add security IP tests - #58369
Conversation
…ests for IP security classes - Fix potential null pointer in Range::contains() where Factory::parseAddressString could return null, which would be passed directly to RangeInterface::contains() - Add comprehensive unit tests for Address class (valid/invalid parsing, isValid, matches, toString) - Add comprehensive unit tests for Range class (valid/invalid parsing, isValid, contains, toString) - Add comprehensive unit tests for Factory class (interface compliance, integration tests) Signed-off-by: amussara <amussara@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Null pointer fix in Range::contains() + 33 new PHP tests. 355 lines.