Skip to content

refactor(settings): simplify PHP templates and reduce duplication - #59088

Open
joshtrichards wants to merge 14 commits into
masterfrom
jtr/refactor-settings-templates-separation-readability
Open

refactor(settings): simplify PHP templates and reduce duplication#59088
joshtrichards wants to merge 14 commits into
masterfrom
jtr/refactor-settings-templates-separation-readability

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Mar 19, 2026

Copy link
Copy Markdown
Member

Summary

Cleaned up Settings PHP templates to make them easier to read and maintain.

Key Changes:

  • Moved repeated logic and checks into local variables.
  • Replaced redundant markup with loops and arrays.
  • Flattened nested conditionals and standardized formatting.

Notes:

  • No intended functional/UI changes; strictly a code quality refactor.
  • All labels, links, and visibility logic remain intact.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ven loop

Signed-off-by: Josh <josh.t.richards@gmail.com>
…onfig

Signed-off-by: Josh <josh.t.richards@gmail.com>
… array

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: settings labels Mar 19, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Mar 20, 2026
@joshtrichards
joshtrichards marked this pull request as ready for review March 20, 2026 20:05
@joshtrichards
joshtrichards requested a review from a team as a code owner March 20, 2026 20:05
@joshtrichards
joshtrichards requested review from Altahrim, ArtificialOwl, CarlSchwan and icewind1991 and removed request for a team March 20, 2026 20:05
@joshtrichards joshtrichards changed the title refactor(settings): simplify PHP templates with data-driven rendering and cleaner control flow refactor(settings): simplify PHP templates and reduce duplication Apr 12, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jun 9, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants