fix(files_external): Move MountConfig to non-static services - #60318
Merged
Conversation
come-nc
force-pushed
the
fix/remove-mountconfig-skiptest
branch
from
May 12, 2026 09:28
bb527f0 to
b81d88f
Compare
come-nc
changed the title
come-nc
force-pushed
the
fix/remove-mountconfig-skiptest
branch
from
May 12, 2026 11:47
1cfd87a to
b56c5d7
Compare
Contributor
Author
|
It feels like all code related to legacy |
come-nc
added
3. to review
come-nc
force-pushed
the
fix/remove-mountconfig-skiptest
branch
from
May 12, 2026 14:26
00637d9 to
5ed85f4
Compare
come-nc
marked this pull request as ready for review
May 12, 2026 14:26
come-nc
requested review from
Altahrim,
CarlSchwan,
icewind1991,
leftybournes,
salmart-dev and
susnux
and removed request for
a team
May 12, 2026 14:26
8 tasks
susnux
reviewed
May 12, 2026
Comment on lines
+6
to
+9
| * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-FileCopyrightText: 2016 ownCloud, Inc. | ||
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Not really, it’s moved around code mostly.
artonge
approved these changes
May 13, 2026
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
They were always skipped and the tested class does not exist. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-mountconfig-skiptest
branch
from
May 18, 2026 12:11
5ed85f4 to
7439b3d
Compare
susnux
approved these changes
May 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gets rid of ugly static class.
Checklist
3. to review, feature component)stable32)AI (if applicable)