chore(psalm): forbid iconv - #60655
Merged
Merged
Conversation
10 tasks
Antreesy
approved these changes
May 22, 2026
Member
|
cs does not support something like this, right? That would allow bringing it to all apps with the shared config 🙈 |
Member
Author
|
couldn't find such thing unfortunately. but yeah, was also wondering how we could best bring this to apps |
come-nc
approved these changes
May 26, 2026
ChristophWurst
force-pushed
the
chore-psalm-forbid-iconv
branch
from
May 26, 2026 11:55
a528283 to
1194da6
Compare
iconv transliteration is locale- and config-dependent; use UnicodeString::ascii() from symfony/string instead. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
psalm*.xml and build/psalm-baseline*.xml were missing from the paths-filter, so PRs touching only those files would skip all Psalm jobs. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
chore-psalm-forbid-iconv
branch
from
June 1, 2026 10:52
1194da6 to
b9f571a
Compare
ChristophWurst
added
3. to review
ChristophWurst
marked this pull request as ready for review
June 1, 2026 10:52
ChristophWurst
requested review from
CarlSchwan,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
June 1, 2026 10:52
nickvergessen
approved these changes
Jun 9, 2026
come-nc
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconv transliteration is locale- and config-dependent; use UnicodeString::ascii() from symfony/string instead.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)