fix(files,systemtags): correct tag-folder breadcrumb, DAV root filtering, and nav label - #60657
fix(files,systemtags): correct tag-folder breadcrumb, DAV root filtering, and nav label#60657deic-cloud wants to merge 2 commits into
Conversation
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
There was a rebase issue or something that resulted in this PR having a commit touching version.php.
Please rebase on master with only your changes.
…tering
- BreadCrumbs: fall back to activeFolder.displayname while path store is
not yet populated (tag folder before REPORT completes)
- files store onUpdatedNode: skip nodes whose root is not the files DAV
root — systemtag folder nodes share the integer-ID namespace but live
under /systemtags and cannot be fetched via /files/{uid}; this prevents
spurious 404s when systemtags:node:updated fires
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7fefa2c to
5a197a7
Compare
|
Rebased on current master — thanks for the review. |
Tags are represented as Folder nodes with an 'is-tag' attribute set by the systemtags app. getSummaryFor now detects these and uses the 'systemtags' translation domain for the count, so the footer reads '1 tag' rather than '1 folder'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Still not good, your PR is changing the issue template and the workflows.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Summary
Three related fixes for the systemtags/files integration:
BreadCrumbs.vue — Fall back to
activeFolder.displaynamewhile the path store is not yet populated (e.g. a tag folder before the REPORT response completes). Previously the breadcrumb showed a raw path segment instead of the tag name.files store
onUpdatedNode— Filter nodes to only those under the files DAV root before fetching updates. Systemtag folder nodes share the integer-ID namespace with regular files but live under/systemtags; attempting to re-fetch them via the/files/{uid}DAV client caused spurious 404s wheneversystemtags:node:updatedfired (e.g. when tag chips are rendered).systemtagsView.ts — Rename the navigation entry from
'Tags'to'All tags'to match the label shown in the left sidebar and avoid confusion with per-tag views.Test plan
🤖 Generated with Claude Code