refactor: consolidate app loading logic in bootstrap process - #61560
Merged
Conversation
susnux
added
the
♻️ refactor
susnux
marked this pull request as ready for review
June 24, 2026 09:59
susnux
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
June 24, 2026 09:59
salmart-dev
reviewed
Jun 24, 2026
salmart-dev
approved these changes
Jun 24, 2026
Remove duplicated calls to `loadApps` by consolidating the logic. - First we keep loading authentication apps - Then we try to login the user if needed - Then load filesystem and logging - Then - if not CLI - load everything else (if possible) The flow is not really changed, but tried to make it more clear at what step which apps are loaded. This also allows to have a specifc point in the execution flow where all app loading is done so we can emit an event for this in the future. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicated calls to
loadAppsby consolidating the logic.The flow is not really changed, but tried to make it more clear at what step which apps are loaded.
This also allows to have a specifc point in the execution flow where all app loading is done so we can emit an event for this in the future.
Checklist
3. to review, feature component)stable32)AI (if applicable)