perf(group): Cache group membership in distributed cache - #62581
Open
CarlSchwan wants to merge 4 commits into
Open
perf(group): Cache group membership in distributed cache#62581CarlSchwan wants to merge 4 commits into
CarlSchwan wants to merge 4 commits into
Conversation
CarlSchwan
requested review from
Altahrim,
icewind1991,
provokateurin and
salmart-dev
and removed request for
a team
July 27, 2026 13:42
CarlSchwan
force-pushed
the
carl/cache-group-membership
branch
5 times, most recently
from
July 27, 2026 18:43
c948aff to
056a23d
Compare
And move the group management listener registration in the core app instead of the files_sharing app (which can be disabled). Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Not used anymore in github.com/nextcloud and there is a modern replacement since NC 18 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/cache-group-membership
branch
from
July 31, 2026 08:40
056a23d to
3dca2f3
Compare
artonge
reviewed
Jul 31, 2026
| } | ||
|
|
||
| #[\Override] | ||
| public function handle(Event $event): void { |
Collaborator
There was a problem hiding this comment.
This is unexpected to have logic here. Shouldn't we have a dedicated listener for that?
Comment on lines
+386
to
+397
| public function handle(Event $event): void { | ||
| if ($event instanceof BeforeGroupDeletedEvent) { | ||
| unset($this->cachedGroups[$event->getGroup()->getGID()]); | ||
| $this->cachedUserGroups->clear(); | ||
| $this->cachedUserGroupsLocal = []; | ||
| } | ||
|
|
||
| if ($event instanceof BeforeUserAddedEvent || $event instanceof BeforeUserRemovedEvent) { | ||
| $this->cachedUserGroups->remove($event->getUser()->getUID()); | ||
| unset($this->cachedUserGroupsLocal[$event->getUser()->getUID()]); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Same for that listener handle, shouldn't we have a dedicated file for that?
Comment on lines
+257
to
266
| public function handle(Event $event): void { | ||
| if ($event instanceof GroupDeletedEvent) { | ||
| $this->postDeleteGroup($event->getGroup()); | ||
| } | ||
|
|
||
| if ($event instanceof UserDeletedEvent) { | ||
| $this->postDeleteUser($event->getUser()); | ||
| } | ||
| } | ||
| } |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
And move the group management listener registration in the core app instead of the files_sharing app (which can be disabled).
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)