chore: remove deprecated global libraries - #62677
Open
susnux wants to merge 2 commits into
Open
Conversation
Those aliases were deprecated since Nextcloud 17 and scheduled for removal since Nextcloud 20. No app uses them except `oc_requesttoken` for which I reported this: - nextcloud/passman#869 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- `clipboard` => just use native `navigator.clipboard` - `davclient.js` => use `webdav` or `@nextcloud/files` - `moment` => use `@nextcloud/moment` or better native `Intl.DateTimeFormat` or `Temporal` API - `underscore` => just use moder ES2015+ syntax Adjusted core (remove usage of `_`) to be able to fully drop those libraries as dependencies (except `moment` which we still use in some legacy apps). Now that `davclient.js` is gone we also can re-enable the `Validate package-lock.json` step on CI. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
icewind1991
force-pushed
the
chore/deprecated-globals
branch
from
July 29, 2026 23:01
828e85e to
319a649
Compare
CarlSchwan
approved these changes
Jul 30, 2026
susnux
marked this pull request as ready for review
July 30, 2026 09:20
susnux
requested review from
Altahrim,
come-nc,
icewind1991,
kristian-zendato,
nfebe and
skjnldsv
and removed request for
a team and
skjnldsv
July 30, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clipboard=> just use nativenavigator.clipboarddavclient.js=> usewebdavor@nextcloud/filesmoment=> use@nextcloud/momentor better nativeIntl.DateTimeFormatorTemporalAPIunderscore=> just use moder ES2015+ syntaxAdjusted core (remove usage of
_) to be able to fully drop those libraries as dependencies (exceptmomentwhich we still use in some legacy apps).Now that
davclient.jsis gone we also can re-enable theValidate package-lock.jsonstep on CI.Checklist
3. to review, feature component)stable32)AI (if applicable)