allow every with direct access to a shared file to modify all shares for the file - #63036
Open
icewind1991 wants to merge 4 commits into
Open
allow every with direct access to a shared file to modify all shares for the file#63036icewind1991 wants to merge 4 commits into
icewind1991 wants to merge 4 commits into
Conversation
icewind1991
changed the title
icewind1991
force-pushed
the
unified-sharing-native-owner
branch
8 times, most recently
from
August 12, 2026 19:53
b6e04d8 to
fb0fc5e
Compare
# This is the 1st commit message: feat: allow users with "native" access to see all shares of a file Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # lib/unstable/Sharing/Source/IShareSourceType.php # tests/lib/Sharing/AbstractSharingManagerTests.php # Conflicts: # lib/private/Sharing/SharingBackend.php # tests/lib/Sharing/AbstractSharingManagerTests.php # The commit message #2 will be skipped: # fixup! feat: allow users with "native" access to see all shares of a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-sharing-native-owner
branch
from
August 14, 2026 16:16
fb0fc5e to
74aa092
Compare
icewind1991
added
3. to review
icewind1991
marked this pull request as ready for review
August 14, 2026 16:17
icewind1991
requested review from
Altahrim,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
August 14, 2026 16:17
Member
Author
|
I think this is "ready" |
icewind1991
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow all users that have direct (not through a share) access, and share permissions to a file access to see and modify all shares for that file, even ones created by other users.
Non-owner are still unable to change the share sources, as modifying the share sources can impact who has "direct" access to the share. Which adds a whole list of potential issues.
This mirrors the existing logic around
IShareOwnerlessMount,but makes the behavior work automatically instead of mounts having to opt-in. Afaik this is equivilent since all mounts I'm aware of that this behavior would trigger for (external storage, groupfolders) opt-in toIShareOwnerlessMount.Edit: switched to to still require the explicit mount opt-in
Requires
Checklist
3. to review, feature component)stable32)AI (if applicable)