Skip to content

fix(appstore): honor subclass cache invalidation duration in fetchers - #63131

Open
joshtrichards wants to merge 2 commits into
masterfrom
jtr/fix-appstore-invalidation
Open

fix(appstore): honor subclass cache invalidation duration in fetchers#63131
joshtrichards wants to merge 2 commits into
masterfrom
jtr/fix-appstore-invalidation

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Aug 10, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

AppDiscoverFetcher declares:

public const INVALIDATE_AFTER_SECONDS = 86400;

However, the base class (Fetcher) uses self::INVALIDATE_AFTER_SECONDS, causing AppDiscoverFetcher's override value to be ignored.

Therefore the discover fetcher does not actually use 24 hours through this mechanism; it still uses the base class’s one-hour/15-minute thresholds.

Changes:

  • Use late static binding when resolving INVALIDATE_AFTER_SECONDS.

Allows AppDiscoverFetcher to use its existing 24-hour cache duration override as (presumably) intended. Preserves the existing default duration for fetchers that do not override the constant.

TODO

  • Backport

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Aug 10, 2026
@joshtrichards
joshtrichards requested a review from a team as a code owner August 10, 2026 14:47
@joshtrichards
joshtrichards requested review from leftybournes and provokateurin and removed request for a team August 10, 2026 14:47
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Aug 10, 2026
@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable34

@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable33

@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable32

@joshtrichards joshtrichards changed the title fix(appstore): honor subclass cache invalidation duration in app store fetchers fix(appstore): honor subclass cache invalidation duration in fetchers Aug 10, 2026

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 10, 2026
@CarlSchwan
CarlSchwan enabled auto-merge August 10, 2026 15:40
Signed-off-by: Josh <josh.t.richards@gmail.com>
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: apps management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants