Update ITable.php to include comment - #63177
Conversation
|
Thanks! |
In Forms with NC35 the Psalm actions fail because `comment` is missing in the docblock for `addColumn` and `modifyColumn`: https://github.com/nextcloud/forms/actions/runs/31592467991/job/94100460339?pr=3578 This adds the missing array key to the docblocks. Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: Carl Schwan <carl@carlschwan.eu>
417314b to
8bc710c
Compare
|
@CarlSchwan thanks for the quick review :) in the same error log, you can find that the function name for changing a column has changed between migrations for NC34 and NC35. Until now, we used Now with |
|
@Chartman123 technically it will still work because |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
ok, then we'll adjust all existing migrations to the correct calls :) |
But that will break all existing apps. Not hard but from linting. |
|
|
Summary
In Forms with NC35 the Psalm actions fail because
commentis missing in the docblock foraddColumnandmodifyColumn:https://github.com/nextcloud/forms/actions/runs/31592467991/job/94100460339?pr=3578
This adds the missing array key to the docblocks.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)