Ignore node modules when running integration tests in Docker - #1679
Merged
nickvergessen merged 2 commits intoApr 8, 2019
Merged
Conversation
This improves its readability and makes possible to add new parameters more cleanly. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Node modules can take a lot of space, causing the copy of the local Git working directory of Nextcloud to the container to be slow. However, they are not needed when running the integration tests, so now they are excluded from the copy. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
nickvergessen
approved these changes
Apr 8, 2019
nickvergessen
deleted the
ignore-node-modules-when-running-integration-tests-in-docker
branch
April 8, 2019 11:03
|
backport to stable15 in #1687 |
|
backport to stable14 in #1688 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of nextcloud/server#14737