fix(sync): reset #sending flag when no active connection on sendStepsNow - #8963
Merged
Conversation
Without this fix, a connection loss during step push setup leaves before calling sendStepsNow(), so all subsequent local changes are silently dropped — never sent to the server — even after the connection recovers. Signed-off-by: omnizs38 <omnizs@proton.me>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
6 tasks
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
silverkszlo
approved these changes
Aug 4, 2026
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, a connection loss during step push setup leaves before calling sendStepsNow(), so all subsequent local changes are silently dropped — never sent to the server — even after the connection recovers.
This PR supersedes #8796, where the author didn't reply any longer and I lack permissions to push changes to the fork branch.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)