build: shim for invoking node w/o .exe from WSL - #43948
Conversation
7295f00 to
04e8794
Compare
This issue has been described in - nodejs#43861 Reason for using build subsystem - Shims will be just copied in the stage_package label of vcbuild.bat Fixes: nodejs#43861
04e8794 to
4895d42
Compare
| copy /Y ..\tools\msvs\node %TARGET_NAME%\ > nul | ||
| if errorlevel 1 echo Cannot copy node && goto package_error |
There was a problem hiding this comment.
How does this affect non-WSL? What happens when I type node in cmd.exe? In cygwin's bash.exe?
There was a problem hiding this comment.
-
cygwin's bash will run this new shim
node, which will run the originalnode.exe. -
cmd.exe will run the original
node.exeimmediately (files with exe extension take precendence). -
This idea of having 2 shims in the bin directory (one without extension for sh/bash shells and one with an extension .exe/.cmd/.bat for cmd/powershell shells) is not new, and is used by a lot of apps/packages, vscode and npm use this for example
|
This pull request has been marked as stale due to 90 days of inactivity. |
This issue has been described in -
#43861
Reason for using build subsystem -
Shims will be just copied in the stage_package label of vcbuild.bat
Fixes: #43861