stream: skip null output from stateful transforms#64462
Conversation
Treat null yielded by sync and async stateful transforms as no output, consistent with transform normalization semantics. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64462 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 741 741
Lines 241375 241606 +231
Branches 45483 45536 +53
==========================================
+ Hits 217800 218036 +236
+ Misses 15129 15109 -20
- Partials 8446 8461 +15
🚀 New features to boost your workflow:
|
|
I was under the impression that stateful transformers should not be yielding |
A
And the bug is explained in #64461 @Renegade334 Would you like to create an issue on the specification? I don't see a block from you, but I've removed |
Fixes: #64461
Stateful transforms currently pass
nulloutput to the flatteninghelpers, causing
ERR_INVALID_ARG_TYPE. Transform outputnormalization defines
nullas no output.Skip
nullbefore flattening stateful transform output in both thesync and async paths.