doc: document http2 header constants#64548
Open
harjothkhara wants to merge 1 commit into
Open
Conversation
Signed-off-by: harjoth <harjoth.khara@gmail.com>
Collaborator
|
Review requested:
|
harjothkhara
marked this pull request as ready for review
July 17, 2026 00:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #25952.
Related: #64235, which was closed unmerged after addressing the compatibility
example and leaving the constants documentation for a follow-up.
This change:
HTTP2_HEADER_*constants;interchangeable with accepted literal header names;
validation, trailers, and connection-specific fields;
are set directly through
writeHead().The documentation is the correct fix boundary because the runtime constants
and behavior already exist. This change does not alter HTTP/2 runtime behavior,
public APIs, or compatibility. The blast radius is limited to
doc/api/http2.md.Verification
The full documentation target passed:
The existing HTTP/2 binding test passed:
All documented constant names and values were compared with the current
runtime export:
The committed diff also passes:
Real-behavior proof
This uses an actual HTTP/2 compatibility server and client. It compares a
response using
HTTP2_HEADER_CONTENT_TYPEwith one using the mixed-caseliteral
Content-Type, verifies the client-visible status, headers, and body,and checks compatibility-API rejection of
HTTP2_HEADER_STATUS.AI-assisted: developed with OpenAI Codex; I reviewed the documentation and verified the behavior and test results above.