ffi: evaluate function signatures once#64559
Open
trivikr wants to merge 1 commit into
Open
Conversation
Function signatures were read by the native implementation and then read again while creating JavaScript wrappers. Accessors, proxies, or mutations could therefore produce different native and JavaScript signatures. Build wrappers from signature metadata captured by native code instead. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
Collaborator
|
Review requested:
|
nodejs-github-bot
added
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64559 +/- ##
==========================================
+ Coverage 90.21% 90.23% +0.01%
==========================================
Files 739 739
Lines 241650 241740 +90
Branches 45542 45536 -6
==========================================
+ Hits 218013 218138 +125
+ Misses 15155 15119 -36
- Partials 8482 8483 +1
🚀 New features to boost your workflow:
|
mcollina
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64558
Function signatures passed to
DynamicLibrary.getFunction()andDynamicLibrary.getFunctions()were evaluated twice. The nativeimplementation parsed the signature first, after which the JavaScript wrapper
reread
signature.argumentsandsignature.return.Accessors, proxies, or mutations could therefore give the native call
interface and JavaScript wrapper different signatures. For example, an
eight-argument native function could be exposed as a one-argument wrapper,
allowing native code to read arguments that the wrapper did not supply.
This change builds wrappers exclusively from the signature metadata attached
by the native implementation. It also simplifies
wrapFFIFunction()so futurecallers cannot supply separate signature values.
Assisted-by: openai:gpt-5.6-sol