Skip to content

translations: fix missing header ID `enabling-remote-debugging-scenar… - #2532

Merged
Trott merged 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-missing-id
Sep 8, 2019
Merged

translations: fix missing header ID `enabling-remote-debugging-scenar…#2532
Trott merged 1 commit into
nodejs:masterfrom
XhmikosR:master-xmr-missing-id

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Sep 7, 2019

Copy link
Copy Markdown
Contributor

…ios`.

Note that I didn't update the files I have open PRs to remove. Also, there are probably more cases like this, I just happened to stumble upon this one.

@Aissaoui-Ahmed
Aissaoui-Ahmed requested review from a user and expitly September 7, 2019 18:22
@Trott

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

HTML comments become header ids for linking? How did I not already know this??!!

@ghost

ghost commented Sep 8, 2019

Copy link
Copy Markdown

@Trott, This is a feature done by me, because as you know, non-English characters WON'T generate any id in English alphabets, so we should support non-English characters to generate their IDs.
Here's the link:#2045, Maybe you have forgotten ;)

@Trott

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

Now I'm curious: What was the reason for processing HTML comments rather than putting a tags directly in the markup? <a name="foo"></a>

@Trott

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

Now I'm curious: What was the reason for processing HTML comments rather than putting a tags directly in the markup? <a name="foo"></a>

Answering my own question: Maybe it's to generate id attributes in the header elements rather than using a elements.

@Trott
Trott merged commit e226f0e into nodejs:master Sep 8, 2019
@XhmikosR

XhmikosR commented Sep 8, 2019 via email

Copy link
Copy Markdown
Contributor Author

@XhmikosR
XhmikosR deleted the master-xmr-missing-id branch September 8, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants