Skip to content

Put llhttp parser at dependencies list - #2722

Merged
Trott merged 5 commits into
nodejs:masterfrom
juanarbol:llhttp
Nov 24, 2019
Merged

Put llhttp parser at dependencies list#2722
Trott merged 5 commits into
nodejs:masterfrom
juanarbol:llhttp

Conversation

@juanarbol

Copy link
Copy Markdown
Member

I saw today an error on dependencies list, http-parser listed on top, but llhttp seems to be the right name, also, llhttp had http-parser docs link.

@XhmikosR

Copy link
Copy Markdown
Contributor

Please check if this needs to be applied to translations.

@juanarbol

juanarbol commented Oct 27, 2019

Copy link
Copy Markdown
Member Author

Yeap, an update is required in:

  1. ar
  2. ja
  3. ko
  4. pt-br
  5. ru
  6. uk
  7. zn-cn

But I don't know how to change the description in these languages; when I say description, I'm saying: "HTTP parsing is handled by a lightweight TypeScript and C library called llhttp..."

@XhmikosR
XhmikosR self-requested a review November 20, 2019 08:14
@XhmikosR
XhmikosR requested review from Trott and richardlau November 20, 2019 09:04
@XhmikosR

Copy link
Copy Markdown
Contributor

If anyone merges this and it's not me, please don't squash the patches.

Comment thread locale/pt-br/docs/meta/topics/dependencies.md

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese looks good to me

@ghost

ghost commented Nov 24, 2019

Copy link
Copy Markdown

@nodejs/website , Please have a review of the changed translations for all the other languages.

@yous

yous commented Nov 24, 2019

Copy link
Copy Markdown
Contributor

ko/ seems okay.

@Trott

Trott commented Nov 24, 2019

Copy link
Copy Markdown
Member

I'm going to go ahead and land this. If any of the translations need improvements, they can certainly happen in a separate PR.

@Trott

Trott commented Nov 24, 2019

Copy link
Copy Markdown
Member

If anyone merges this and it's not me, please don't squash the patches.

Using 'Rebase and merge" rather than "Squash and merge'".

@Trott
Trott merged commit 9ba3c15 into nodejs:master Nov 24, 2019
@Trott

Trott commented Nov 24, 2019

Copy link
Copy Markdown
Member

People can (and still) should check the translations to make sure we didn't introduce any errors here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants