logs: add Enabled support to Logger API, SDK, and LogRecordProcessor by ocelotl · Pull Request #5380 · open-telemetry/opentelemetry-python

ocelotl · 2026-07-01T23:07:57Z

Summary

Implements the Enabled chain from the OpenTelemetry Logs specification, closes #5360.

API Logger.enabled(context, severity_number, event_name) -> bool: non-abstract default returning True; NoOpLogger returns False; ProxyLogger delegates to the real logger.
SDK LogRecordProcessor.enabled(context, instrumentation_scope, severity_number, event_name) -> bool: non-abstract default returning True — processors opt into filtering by overriding this method.
SDK SynchronousMultiLogRecordProcessor / ConcurrentMultiLogRecordProcessor: enabled() returns False when no processors are registered, False when all processors return False, True otherwise.
SDK Logger.enabled(): checks LoggerConfig.is_enabled first, then delegates to the multi-processor with the logger's instrumentation scope.

Test plan

New SDK tests covering: no processors → False, processor present → True, disabled logger config → False, args forwarded to processor, all processors disabled → False, one processor enabled → True
New API tests covering: NoOpLogger.enabled() → False, ProxyLogger.enabled() delegates to real logger, ProxyLogger.enabled() falls back to no-op

carlosalberto · 2026-07-10T00:15:03Z

Symbolic approval. Overall good, just a non blocking comment regarding the default implementation for Logger.enabled()

xrmx

Small nit on the changelog but LGTM

hectorhdzg

LGTM. Nit: since making Logger.enabled abstract breaks external Logger subclasses, worth prefixing the 5380.changed entry with [BREAKING] like we did in #4676 / #4647

ocelotl · 2026-07-22T20:56:50Z

LGTM. Nit: since making Logger.enabled abstract breaks external Logger subclasses, worth prefixing the 5380.changed entry with [BREAKING] like we did in #4676 / #4647

We are not yet stable, so this is not breaking ✌️

aabmass · 2026-08-04T18:28:40Z

LGTM. Nit: since making Logger.enabled abstract breaks external Logger subclasses, worth prefixing the 5380.changed entry with [BREAKING] like we did in #4676 / #4647

The PRs Hector linked were for logs too. It's still breaking change even to logging (even if it's in an unstable component) so it's nice to call attention in the changelog

Copilot

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds enabled() support across the Logs API + SDK to allow instrumentation to cheaply decide whether to construct/emit log records.

Changes:

Introduces enabled() on API Logger and SDK Logger/LogRecordProcessor, including multi-processor aggregation behavior.
Adds SDK and API tests covering enabled/no-op/proxy delegation scenarios.
Adds changelog entries documenting the API/SDK change.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
opentelemetry-sdk/tests/logs/test_logs.py	Adds SDK tests for `Logger.enabled()` behavior with/without processors and config gating.
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/init.py	Implements `enabled()` on `LogRecordProcessor`, multi-processors, and SDK `Logger`.
opentelemetry-api/tests/logs/test_proxy.py	Adds API tests for `ProxyLogger.enabled()` delegation and `NoOpLogger.enabled()`.
opentelemetry-api/src/opentelemetry/_logs/_internal/init.py	Adds `enabled()` to API `Logger` plus implementations in `NoOpLogger` and `ProxyLogger`.
.changelog/5380.changed	Notes a breaking requirement for `Logger` subclasses regarding `enabled()`.
.changelog/5380.added	Announces `enabled()` support addition across API/SDK and processors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Implements the Enabled chain from the OpenTelemetry Logs specification: - API Logger.enabled(context, severity_number, event_name) -> bool: default True; NoOpLogger returns False; ProxyLogger delegates. - SDK LogRecordProcessor.enabled(...) -> bool: non-abstract default True so existing processors opt-in by overriding. - SDK SynchronousMultiLogRecordProcessor/ConcurrentMultiLogRecordProcessor: enabled() returns False when no processors are registered, False when all processors return False, otherwise True. - SDK Logger.enabled(): checks LoggerConfig.is_enabled first, then delegates to the multi-processor with the instrumentation scope. Closes open-telemetry#5360

…g fragment Add pylint disable=no-self-use annotations to the enabled() default implementations in the Logger API and LogRecordProcessor SDK base classes, matching the existing pattern used for force_flush(). Also add the missing .changelog/5380.added fragment required by the changelog CI check.

Since the logs API is not yet stable, adding enabled() as an abstract method does not break a released version. All concrete Logger subclasses (NoOpLogger, ProxyLogger, and the SDK Logger) already provide an implementation.

…__.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>

Set enabled.return_value = True on the mock processor and assert it was called, so the test verifies the multi-processor wiring rather than passing on a bare Mock's truthiness.

pylint reports unused-argument on the parameter lines, so the disable on the return statement did not suppress it. Fold it into the disable on the def line where it is effective.

Reflow assertions to the project's ruff-format style so the precommit check passes.

Even though logs are not yet stable, adding an abstract enabled() breaks external Logger subclasses, so call it out in the changelog.

ocelotl · 2026-08-07T22:26:18Z

Good point, agreed. Prefixed the 5380.changed entry with [BREAKING] in 5bab95b to call attention to it in the changelog, even though logs are still unstable.

opentelemetry-pr-dashboard · 2026-08-14T16:52:22Z

Pull request dashboard status

Waiting on maintainers · refreshed 2026-08-17 17:31 UTC

Merge when ready.

Status above doesn't look right?

Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

ocelotl force-pushed the issue_5360 branch from 35756ae to 6cccbee Compare July 3, 2026 23:42

ocelotl marked this pull request as ready for review July 3, 2026 23:45

ocelotl requested a review from a team as a code owner July 3, 2026 23:45

otelbot-python Bot added this to Python PR digest Jul 3, 2026

carlosalberto reviewed Jul 9, 2026

View reviewed changes

Comment thread opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py Outdated

carlosalberto reviewed Jul 9, 2026

View reviewed changes

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

carlosalberto approved these changes Jul 10, 2026

View reviewed changes

herin049 reviewed Jul 14, 2026

View reviewed changes

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Comment thread .changelog/5380.added Outdated

ocelotl force-pushed the issue_5360 branch from ef56c8c to f6d6827 Compare July 16, 2026 02:46

ocelotl requested a review from herin049 July 16, 2026 03:03

ocelotl force-pushed the issue_5360 branch from e33fddc to 9cd8f14 Compare July 17, 2026 18:32

rads-1996 approved these changes Jul 21, 2026

View reviewed changes

xrmx reviewed Jul 22, 2026

View reviewed changes

Comment thread .changelog/5380.added

xrmx approved these changes Jul 22, 2026

View reviewed changes

ocelotl force-pushed the issue_5360 branch from db42000 to 0256631 Compare July 22, 2026 17:19

hectorhdzg approved these changes Jul 22, 2026

View reviewed changes

github-project-automation Bot moved this to Approved PRs in Python PR digest Jul 22, 2026

aabmass reviewed Aug 4, 2026

View reviewed changes

aabmass moved this from Approved PRs to Approved PRs that need fixes in Python PR digest Aug 4, 2026

aabmass requested a lite review from Copilot August 4, 2026 18:45

Copilot AI reviewed Aug 4, 2026

View reviewed changes

Copilot started reviewing on behalf of aabmass August 4, 2026 19:20 View session

This was referenced Aug 7, 2026

Public API for setting logger/tracer configuration programmatically #5524

Open

Logs Enabled: implement Development-status conditions (minimum_severity, trace_based) #5525

Open

ocelotl added 3 commits August 7, 2026 16:47

docs(changelog): prefix 5380 entry with affected package names

a0c73f9

ocelotl and others added 5 commits August 7, 2026 16:47

logs: make Logger.enabled abstract

28bf8b3

Since the logs API is not yet stable, adding enabled() as an abstract method does not break a released version. All concrete Logger subclasses (NoOpLogger, ProxyLogger, and the SDK Logger) already provide an implementation.

Add changelog entry noting Logger subclasses must implement enabled

22df2d9

Update opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init…

8d19019

…__.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>

Update opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init…

bae9ba0

…__.py Co-authored-by: Aaron Abbott <aaronabbott@google.com>

test(logs): assert enabled() consults processor return value

7c80309

Set enabled.return_value = True on the mock processor and assert it was called, so the test verifies the multi-processor wiring rather than passing on a bare Mock's truthiness.

ocelotl force-pushed the issue_5360 branch from 1b8e2a9 to 7c80309 Compare August 7, 2026 21:50

ocelotl added 2 commits August 7, 2026 16:53

fix(logs): move unused-argument disable to enabled() signature

e2e3813

pylint reports unused-argument on the parameter lines, so the disable on the return statement did not suppress it. Fold it into the disable on the def line where it is effective.

style(logs): apply ruff-format to enabled() tests and API

ff6de5e

Reflow assertions to the project's ruff-format style so the precommit check passes.

ocelotl requested a review from aabmass August 7, 2026 22:24

docs(changelog): mark Logger.enabled subclass requirement as [BREAKING]

5bab95b

Even though logs are not yet stable, adding an abstract enabled() breaks external Logger subclasses, so call it out in the changelog.

opentelemetry-pr-dashboard Bot mentioned this pull request Aug 14, 2026

Pull Request Dashboard #5550

Open

lzchen approved these changes Aug 17, 2026

View reviewed changes

github-project-automation Bot moved this from Approved PRs that need fixes to Approved PRs in Python PR digest Aug 17, 2026

Uh oh!

Conversation

ocelotl commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Uh oh!

Uh oh!

carlosalberto commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrmx left a comment

Choose a reason for hiding this comment

Uh oh!

hectorhdzg left a comment

Choose a reason for hiding this comment

Uh oh!

ocelotl commented Jul 22, 2026

Uh oh!

aabmass commented Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocelotl commented Aug 7, 2026

Uh oh!

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request dashboard status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ocelotl commented Jul 1, 2026 •

edited

Loading

carlosalberto commented Jul 10, 2026 •

edited

Loading

opentelemetry-pr-dashboard Bot commented Aug 14, 2026 •

edited

Loading