fix: restrict condition name to 50 characters - #187
Conversation
4ba8caa to
9403bab
Compare
| string name = 1 [ | ||
| (validate.rules).string = { | ||
| pattern: "^[^\\s]{2,256}$" | ||
| pattern: "^[^\\s]{1,50}$" |
There was a problem hiding this comment.
is there a specific byte length that we are targeting, or are we only concerned about character count? Considering byte length, a maximum of 200 bytes (UTF-8 4-byte characters) would be valid for 50 characters.
if the assumption is that we are limiting to 50 8-bit characters for a maximum of 50 bytes, then more validations will need to be put into place.
|
This PR has had no human activity for 90 days, so it has been marked This is automated backlog grooming, not a judgment on the work. What happens next, unless there is activity:
To keep it open, push a commit or leave a comment, and the clock will reset. For work that should not auto-close, such as an RFC or long-running experiment, ask a maintainer to add |
|
This PR has had no human activity for 30 days since being marked It will be closed in 30 days unless there is new activity. If the work still matters, this is the moment to say so: leave a comment, push a commit, or ask a maintainer to add If this work is no longer being pursued, no action is needed. |
Description
Restrict character limit of condition down to 50 characters. Left the patterns as they were.
References
openfga/language#319
Review Checklist
main