Small extractions: isGenerator node memo, keep-void yield checks - #6161
Merged
Conversation
The scan walks the whole function body and reflections for the same node are recreated per ask, so the answer is memoized on the node itself and lives and dies with the parser-cached AST. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
…terType Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small branch-agnostic pieces extracted from the resolve-type-rewrite branch:
PhpFunctionFromParserNodeReflection::isGenerator()memoizes the whole-body yield scan on the AST node (reflections for the same node are recreated per ask, so an instance property would not stick; the memo lives and dies with the parser-cached AST).YieldFromTypeRule/YieldTypeRuleread the operand throughgetKeepVoidType()— behavior-neutral today (suite unchanged), keeps the void check honest independent of the void-to-null projection at value reads.@internaldocblock onhasAcceptorTemplateOrLateResolvableParameterType().All suites pass unchanged: NodeScopeResolverTest 1694, full suite 17811,
make phpstan,make cs.🤖 Generated with Claude Code
https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7