Skip to content

Fix fetching geojson when ES6 import is used to load the library - #5763

Merged
archmoj merged 2 commits into
masterfrom
d3-es6-xhr
Jun 24, 2021
Merged

Fix fetching geojson when ES6 import is used to load the library#5763
archmoj merged 2 commits into
masterfrom
d3-es6-xhr

Conversation

@archmoj

@archmoj archmoj commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

Fixes #5753.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jun 23, 2021
@archmoj archmoj added this to the NEXT milestone Jun 23, 2021
Comment thread package.json Outdated
},
"dependencies": {
"@plotly/d3": "^3.6.0",
"@plotly/d3": "git://github.com/plotly/d3.git#591467ae9c2939486ddeae4ed1bb0deca3d611f5",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj
archmoj requested a review from alexcjohnson June 24, 2021 15:21

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 after updating to a new published version of @plotly/d3.

@archmoj
archmoj merged commit 642f529 into master Jun 24, 2021
@archmoj
archmoj deleted the d3-es6-xhr branch June 24, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error fetching geojson when ES6 import is used

2 participants