Skip to content

Deprecate marketing cards module and credit cards component#347

Merged
jonrohan merged 4 commits into
release-9.4.0from
deprecate_stuff
Sep 20, 2017
Merged

Deprecate marketing cards module and credit cards component#347
jonrohan merged 4 commits into
release-9.4.0from
deprecate_stuff

Conversation

@jonrohan

Copy link
Copy Markdown
Member

This PR adds some notes to the primer-cards module and the primer-forms module about upcoming deprecation.

For the primer-cards module, the whole thing is going away in the next major version. So I'm adding a @warn, a banner on the readme, and running npm deprecate primer-cards@"> 0.4.0" "The primer-cards module is being deprecated in the next major version. Use primer-box instead."

For the forms credit cards, I'm adding a warning near the css, until we remove it.

/cc @primer/ds-core

@jonrohan jonrohan requested a review from a team September 16, 2017 00:19
@shawnbot

Copy link
Copy Markdown
Contributor

Nice!

% cd modules/primer-marketing; npm run build

> primer-marketing@5.3.0 build /Users/shawnbot/primer/primer-css/modules/primer-marketing
> primer-module-build index.scss

WARNING: primer-cards: The primer-cards module is being deprecated in the next major version. Use primer-box instead.
Backtrace:
        node_modules/primer-cards/index.scss:2

@jonrohan jonrohan merged commit 4e3d009 into release-9.4.0 Sep 20, 2017
@jonrohan jonrohan deleted the deprecate_stuff branch September 20, 2017 03:34
@shawnbot shawnbot mentioned this pull request Sep 20, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants