Expand warnings output for ResourceWarning by nicoddemus · Pull Request #9682 · pytest-dev/pytest

nicoddemus · 2022-02-13T14:14:12Z

nicoddemus · 2022-02-13T14:15:44Z

Here's the output for the test in the suite:

============================== warnings summary ===============================
test_resource_warning.py::test_resource_warning
  E:\.tmp\pytest-of-Pichau\pytest-1285\test_resource_warning0\test_resource_warning.py:8: ResourceWarning: unclosed file <_io.TextIOWrapper name='E:\\.tmp\\pytest-of-Pichau\\pytest-1285\\tmp-test_resource_warning0\\pytest-of-Pichau\\pytest-1\\test_resource_warning0\\foo.txt' mode='r' encoding='cp1252'>
    open_file(p)
  
  Object allocated at (most recent call first):
    File "E:\projects\pytest\src\_pytest\main.py", line 347
      item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_hooks.py", line 265
      return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_manager.py", line 80
      return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_callers.py", line 39
      res = hook_impl.function(*args)
    File "E:\projects\pytest\src\_pytest\runner.py", line 113
      runtestprotocol(item, nextitem=nextitem)
    File "E:\projects\pytest\src\_pytest\runner.py", line 132
      reports.append(call_and_report(item, "call", log))
    File "E:\projects\pytest\src\_pytest\runner.py", line 221
      call = call_runtest_hook(item, when, **kwds)
    File "E:\projects\pytest\src\_pytest\runner.py", line 260
      return CallInfo.from_call(
    File "E:\projects\pytest\src\_pytest\runner.py", line 340
      result: Optional[TResult] = func()
    File "E:\projects\pytest\src\_pytest\runner.py", line 261
      lambda: ihook(item=item, **kwds), when=when, reraise=reraise
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_hooks.py", line 265
      return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_manager.py", line 80
      return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_callers.py", line 39
      res = hook_impl.function(*args)
    File "E:\projects\pytest\src\_pytest\runner.py", line 168
      item.runtest()
    File "E:\projects\pytest\src\_pytest\python.py", line 1756
      self.ihook.pytest_pyfunc_call(pyfuncitem=self)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_hooks.py", line 265
      return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_manager.py", line 80
      return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
    File "E:\projects\pytest\.env39\lib\site-packages\pluggy\_callers.py", line 39
      res = hook_impl.function(*args)
    File "E:\projects\pytest\src\_pytest\python.py", line 192
      result = testfunction(**testargs)
    File "E:\.tmp\pytest-of-Pichau\pytest-1285\test_resource_warning0\test_resource_warning.py", line 8
      open_file(p)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 1 passed, 1 warning in 0.03s =========================

Fix pytest-dev#9644

fschulze

Nice! Thanks for the PR, you beat me to it 😉

fschulze · 2022-02-13T15:08:09Z

+                # Use a leading new line to better separate the (large) output
+                # from the traceback to the previous warning text.
+                msg += (
+                    f"\nObject allocated at (most recent call first):\n{formatted_tb}"


I'm not sure most recent call first is correct here, maybe just remove it?

fschulze · 2022-02-13T15:08:41Z

    )
+    if warning_message.source is not None:
+        try:
+            import tracemalloc


Are there platforms which don't have tracemalloc available?

Pypy3 CI failed with ImportError: cannot import _tracemalloc, so I went ahead and assumed that was the case, but didn't look into official sources TBH.

It is likely that PyPy doesn't support it at all due to differing memory management.

bluetech

Looks great to me! I left one comment.

bluetech · 2022-02-15T11:22:10Z

+    except ImportError:
+        has_tracemalloc = False
+
+    pytester.makepyfile(


I think this test (tracemalloc not enabled) will fail if the person running the pytest test suite enables tracemalloc.

Hmm why do you say that? And do you mean running in CPython?

I tried it here:

python -X tracemalloc=20 -m pytest testing\test_warnings.py

And it passes.

Note the try/except is checking if tracemalloc is available at all, which is not on PyPy for example, not if tracemalloc is enabled or not.

I guess python -X tracemalloc=20 doesn't transfer, but an envvar does, so try this:

PYTHONTRACEMALLOC=100 pytest testing/test_warnings.py -k resource

Ahh got it, good catch. 😁

Updated the test, thanks.

Fix pytest-dev#9644

nicoddemus force-pushed the 9644-resource-warning branch from db8dd8e to 92da79a Compare February 13, 2022 14:24

Expand warnings output for ResourceWarning

cdd827b

Fix pytest-dev#9644

nicoddemus force-pushed the 9644-resource-warning branch from 92da79a to cdd827b Compare February 13, 2022 14:38

fschulze approved these changes Feb 13, 2022

View reviewed changes

Update output text as per review

01a2f54

bluetech approved these changes Feb 15, 2022

View reviewed changes

Disable tracemalloc for test_resource_warning

b85ea2a

nicoddemus enabled auto-merge (squash) February 15, 2022 12:42

nicoddemus merged commit 9af3e23 into pytest-dev:main Feb 15, 2022

nicoddemus deleted the 9644-resource-warning branch February 15, 2022 13:12

imgbot Bot pushed a commit to kkipngenokoech/pytest that referenced this pull request Apr 18, 2026

Expand warnings output for ResourceWarning (pytest-dev#9682)

529b11d

Fix pytest-dev#9644

imgbot Bot pushed a commit to kkipngenokoech/pytest that referenced this pull request Apr 18, 2026

Expand warnings output for ResourceWarning (pytest-dev#9682)

9b94de6

Fix pytest-dev#9644

Navigation Menu

Uh oh!

Uh oh!

Expand warnings output for ResourceWarning - #9682

Expand warnings output for ResourceWarning#9682
nicoddemus merged 3 commits into
pytest-dev:mainfrom
nicoddemus:9644-resource-warning

nicoddemus commented Feb 13, 2022

Uh oh!

nicoddemus commented Feb 13, 2022

Uh oh!

fschulze left a comment

Uh oh!

fschulze Feb 13, 2022

Uh oh!

fschulze Feb 13, 2022

Uh oh!

nicoddemus Feb 13, 2022

Uh oh!

fschulze Feb 14, 2022

Uh oh!

bluetech left a comment

Uh oh!

bluetech Feb 15, 2022

Uh oh!

nicoddemus Feb 15, 2022

Uh oh!

nicoddemus Feb 15, 2022

Uh oh!

bluetech Feb 15, 2022

Uh oh!

nicoddemus Feb 15, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

nicoddemus commented Feb 13, 2022

Uh oh!

nicoddemus commented Feb 13, 2022

Uh oh!

fschulze left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bluetech left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicoddemus Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicoddemus Feb 15, 2022 •

edited

Loading