Fix ValueError in metric()/scientific() with precision 0#352
Open
santhreal wants to merge 1 commit into
Open
Conversation
scientific() built its format spec as f"{{:.{int(precision)}e}}", so a
negative precision produced an invalid spec ("{:.-1e}") and raised
ValueError. This is reachable from the public API through metric(value,
precision=0): for magnitudes that fall back to scientific notation,
metric() calls scientific(value, precision - 1), i.e. scientific(value,
-1). PR python-humanize#159 added the same max(0, ...) clamp to metric()'s main path but
not to scientific(). Clamp the precision to zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metric(value, precision=0)raisesValueError: Format specifier missing precisionwhen the magnitude falls back toscientific(), becausemetriccallsscientific(value, precision - 1), so precision0becomes-1and builds an invalid format spec"{:.-1e}".scientific(value, -1)directly hits the same path.#159 fixed this for the non-scientific
metricpath; this covers thescientific()fallback it did not reach.scientificnow clamps a negative precision to zero.