Add more data to error message - #8316
Closed
Yay295 wants to merge 3 commits into
Closed
Conversation
Member
|
Could you give an example of how to trigger this error? |
Contributor
Author
|
With #8317, |
Member
|
Would it not be more consistent with the rest of TiffImagePlugin to log the extra information instead? Pillow/src/PIL/TiffImagePlugin.py Lines 1429 to 1435 in eeb3d04 |
Contributor
Author
|
It might. Logging is only used in five files in Pillow though (Image, PcxImagePlugin, PngImagePlugin, TiffImagePlugin, helper). |
Yay295
force-pushed
the
tiff_error_data
branch
from
August 28, 2024 13:32
dc7470f to
b7248be
Compare
Yay295
force-pushed
the
tiff_error_data
branch
from
September 18, 2024 19:51
b7248be to
4eac85c
Compare
Yay295
force-pushed
the
tiff_error_data
branch
from
September 30, 2024 13:28
4eac85c to
7cfb3eb
Compare
Yay295
force-pushed
the
tiff_error_data
branch
from
October 7, 2024 13:55
7cfb3eb to
60eb058
Compare
Yay295
force-pushed
the
tiff_error_data
branch
from
October 12, 2024 23:30
60eb058 to
671d780
Compare
Member
Member
|
I've created #8568 as an alternative to this, using my suggestion of logging. |
Member
|
#8568 has been merged instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the error message from
offset is neither short nor longto
offset is neither short nor long: Tag ID 273 Field Type 16 Field Size 8 Count 1