Fix corrupt output when adding to a dotted key inside an inline table#500
Merged
frostming merged 1 commit intoJun 11, 2026
Merged
Conversation
gaoflow
force-pushed
the
fix/495-dotted-key-inline-table
branch
from
June 10, 2026 04:12
2fa536b to
9c4694c
Compare
frostming
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a key to a dotted-key table inside an inline table produced unparseable output (#495):
InlineTable.as_stringrendered the dotted prefix once and then dumped the materialized table's block-style body verbatim. The fix renders oneprefix.child = valuepair per child (recursing for nested dotted keys), mirroring whatContainer._render_tabledoes for dotted keys in regular tables, so the result isa = {b.c = 1, b.d = 2}. Repeating the prefix is required for correctness: rendering the new key bare ({b.c = 1, d = 2}) would change its meaning toa.d.Fixes #495.