Include conftest.py in the sdist - #121
Merged
Merged
Conversation
The root conftest.py provides the sample_test_file fixture used by the test suite, but it is excluded from the sdist because it is outside the hatchling sdist include list. This makes the PyPI tarball untestable as-is and forces downstream packagers to patch the file back in. Fixes python-tap#107
mblayman
approved these changes
Aug 8, 2026
mblayman
left a comment
mblayman
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root conftest.py provides the sample_test_file fixture used by the test suite, but it is excluded from the sdist because it is outside the hatchling sdist include list. This makes the PyPI tarball untestable as-is and forces downstream packagers to patch the file back in.
Fixes #107